This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Conversation
nchamo
approved these changes
Sep 16, 2020
pablitar
added a commit
that referenced
this pull request
Sep 28, 2020
Restores #1313. Also: New changes: - Changed build scripts to ensure amd.js is included in `decentraland-ecs/artifacts` folder. That was causing a regression. - Enabled scene logs in `preview` mode - typescript property `useDefineForClassFields` must be false to work with the ECS decorators [more info here](arduz-online/ulla@8ccf73f) For future PR: when Typescript 4.1 reaches GA, we should implement this automatic configuration for libraries only: - [Blog post](https://devblogs.microsoft.com/typescript/announcing-typescript-4-1-beta/#declaration-and-outfile-requires-a-package-name-root) - microsoft/TypeScript#39277 Co-authored-by: pablitar <[email protected]> Co-authored-by: Pablo de Haro <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
origin mirror of: #1229 to get the CI working