Skip to content

Conversation

@luna-spirito
Copy link
Contributor

Starting from Apache TinkerPop 3.3.4 Order.incr and Order.decr were deprecated, replaced by Order.asc and Order.desc.

Starting from Apache TinkerPop 3.3.4 `Order.incr` and `Order.decr` were deprecated, replaced by `Order.asc` and `Order.desc`.
@debug-ito debug-ito changed the base branch from master to add-asc-desc January 10, 2023 04:41
@debug-ito
Copy link
Owner

Thanks! I did't know the update.

However, I think we don't have to remove oIncr and oDecr, because someone might want to use greskell against a very old Tinkerpop server. We just need to describe they are deprecated in Tinkerpop 3.3.4 in documentation.

I changed the target branch from master to add-asc-desc. If you are ok, I'll just merge this m-r and add some commits to restore oIncr and oDecr. If you want to revise the branch, just add commits.

@debug-ito debug-ito self-assigned this Jan 10, 2023
@luna-spirito
Copy link
Contributor Author

It's okay. Thank you very much for your project: it's a huge work!

@debug-ito
Copy link
Owner

Thanks for understanding. I'll work on it and release it.

@debug-ito debug-ito merged commit 1ec6e9b into debug-ito:add-asc-desc Jan 10, 2023
@debug-ito
Copy link
Owner

Just released greskell-2.0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants