Force plug-in activation for custom property testers#276
Merged
de-jcup merged 1 commit intode-jcup:masterfrom Jan 17, 2024
Merged
Force plug-in activation for custom property testers#276de-jcup merged 1 commit intode-jcup:masterfrom
de-jcup merged 1 commit intode-jcup:masterfrom
Conversation
This change ensures Eclipse correctly uses the property testers 'isBashFileWithoutExtension' and 'isOpenPathActionEnabled', by setting the 'forcePluginActivation' property in the respective plugin.xml entries. This allows Eclipse to load the property tester class prior to trying to use it - in case the bash editor plug-in was not activated yet. Fixes: de-jcup#275 Signed-off-by: Simeon Andreev <[email protected]>
de-jcup
approved these changes
Jan 17, 2024
Owner
de-jcup
left a comment
de-jcup
left a comment
There was a problem hiding this comment.
Looks great, thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures Eclipse correctly uses the property testers
isBashFileWithoutExtensionandisOpenPathActionEnabled, by setting theforcePluginActivationproperty in the respectiveplugin.xmlentries. This allows Eclipse to load the property tester class prior to trying to use it - in case the bash editor plug-in was not activated yet.Fixes: #275