Skip to content

Fix CMake deprecation warning for old CMake versions#3387

Merged
bors[bot] merged 4 commits intoddnet:masterfrom
heinrich5991:pr_ddnet_cmake_version_werror
Dec 8, 2020
Merged

Fix CMake deprecation warning for old CMake versions#3387
bors[bot] merged 4 commits intoddnet:masterfrom
heinrich5991:pr_ddnet_cmake_version_werror

Conversation

@heinrich5991
Copy link
Member

Fixes #3355

Works around google/googletest#3040.

Checklist

  • Tested the change ingame
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options
  • Written a unit test if it works standalone, system.c especially
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)

These were tests that fail when the blocklist changes.
Declare that we're fine with policies up to 3.19.1. This should fix
policy errors and "too low cmake_minimal_version() errors" for the
forseeable future.
@heinrich5991 heinrich5991 force-pushed the pr_ddnet_cmake_version_werror branch from 5af0a66 to 037b928 Compare December 8, 2020 09:24
@heinrich5991
Copy link
Member Author

Supersedes #3374.

@def-
Copy link
Member

def- commented Dec 8, 2020

bors r+
Thanks

@bors
Copy link
Contributor

bors bot commented Dec 8, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake Deprecation Warning on cmake 3.19.0

2 participants