chore(update-checker): .editorconfig and .gitattributes#33
chore(update-checker): .editorconfig and .gitattributes#33
Conversation
There was a problem hiding this comment.
Thanks for thinking about it, even if it doesn't affect the addon itself.
Let's add it to https://github.com/ddev/ddev-addon-template first.
After that, all downstream add-ons can be updated accordingly (with Update Checker, which could have a proper check for this https://github.com/ddev/ddev-addon-template/blob/main/.github/scripts/update-checker.sh).
We don't actually need all these rules for add-ons. We could use https://github.com/laravel/laravel/blob/13.x/.editorconfig as a base with some changes for [*.sh], etc.
Also the exclusion for .editorconfig export-ignore should be added to .gitattributes (it's not here because I haven't updated this add-on in a long time).
|
@stasadev done. Should I update this MR with the new .editorconfig, or should I close this MR so you can merge in the upstream changes? |
Yes, please update it. |
stasadev
changed the title
|
I updated it. |
2 participants
The Issue
(I didn't create an issue for this)
I was working on a shell script for a different merge request, and noticed that my editor's defaults didn't match ddev conventions. I went looking for a
.editorconfigand didn't find one in this repo.How This PR Solves The Issue
I copied the
.editorconfigfrom ddev/ddev at commit9e1a27142e830b55da9b82ab53c8e1590dc7be3a(which was the HEAD ofmainat time-of-writing) into this repo.Manual Testing Instructions
.shfile in the project using an editor that supports the EditorConfig standard with default configurationtabkey:Automated Testing Overview
I don't think automatically testing text editors is within the scope of the ddev project, although I suppose, if desired, I could try to figure out how to write a browser-based test for a browser-based editor like VSCode, although I feel that would be very brittle and would unnecessarily extend the scope of this issue.
Release/Deployment Notes
Only affects people trying to contribute to this add-on.
Nothing needs to be done on deployment.