Skip to content

build(deps): bump go dependencies, migrate to go-github v88#8492

Merged
stasadev merged 2 commits into
mainfrom
20260618_stasadev_deps
Jun 19, 2026
Merged

build(deps): bump go dependencies, migrate to go-github v88#8492
stasadev merged 2 commits into
mainfrom
20260618_stasadev_deps

Conversation

@stasadev

@stasadev stasadev commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

The Issue

We need to bump go dependencies before v1.25.3

How This PR Solves The Issue

Runs go get -u ./... github.com/moby/[email protected] go.yaml.in/yaml/[email protected], because updating everything is not possible right now:

$ go get -u ./...
go: github.com/ddev/ddev/pkg/dockerutil imports
        github.com/docker/compose/v5/pkg/compose imports
        github.com/docker/compose/v5/internal/tracing imports
        github.com/moby/buildkit/util/tracing/env: cannot find module providing package github.com/moby/buildkit/util/tracing/env

The last update for Docker Compose was a month ago; we can bump it again if a new update is released.

Updates code logic for go-github v88, they made some changes.

And I bumped github.com/asaskevich/govalidator/v12.

Runs golangci-lint run --fix because:

golangci-lint: 
cmd/ddev/cmd/debug-config-yaml.go:105:3: stditerators: NumField/Field loop can simplified using Value.Fields iteration (modernize)
                for i := 0; i < v.NumField(); i++ {
                ^
1 issues:
* modernize: 1
make: *** [Makefile:358: golangci-lint] Error 1

Manual Testing Instructions

GitHub tokens should work as before:

DDEV_GITHUB_TOKEN=dummy ddev add-on get ddev/ddev-redis
DDEV_GITHUB_TOKEN=use-real-token ddev add-on get ddev/ddev-redis

Automated Testing Overview

Release/Deployment Notes

@stasadev
stasadev requested review from a team as code owners June 18, 2026 16:31
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file maintenance labels Jun 18, 2026
@github-actions

github-actions Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Download the artifacts for this pull request:

See Testing a PR.

Open in GitHub Codespaces

@stasadev

stasadev commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

All these fails in tests come from go.yaml.in/yaml/v4 v4.0.0-rc.4 => go.yaml.in/yaml/v4 v4.0.0-rc.5

Running ddev version check...
unable to read global projects list: unable to load DDEV global projects file /Users/testbot/.ddev/project_list.yaml: yaml: construct errors: <unknown position>: yaml: no documents in stream

I'm going to use go.yaml.in/yaml/v4 v4.0.0-rc.4 for now.

@rfay

rfay commented Jun 18, 2026

Copy link
Copy Markdown
Member

Wow, surprising that they'd do that in a rc... Thanks for doing this.

@stasadev

stasadev commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

There are newer Moby releases available, but Docker Compose prevents us from upgrading:

$ go get -u ./... github.com/moby/[email protected] go.yaml.in/yaml/[email protected] 
go: downloading github.com/docker/cli v29.6.0+incompatible
go: downloading github.com/moby/moby/api v1.55.0
go: downloading github.com/moby/moby/client v0.5.0
go: downloading github.com/containerd/containerd/v2 v2.3.2
go: downloading github.com/containerd/containerd v1.7.33
go: upgraded github.com/containerd/containerd/v2 v2.3.1 => v2.3.2
go: upgraded github.com/docker/cli v29.5.3+incompatible => v29.6.0+incompatible
go: upgraded github.com/moby/moby/api v1.54.2 => v1.55.0
go: upgraded github.com/moby/moby/client v0.4.1 => v0.5.0
$ go mod tidy
$ go mod vendor

$ make              
building .gotmp/bin/linux_amd64/ddev from ./cmd/... ./pkg/... GORACE=halt_on_error=1 CGO_ENABLED=0 BUILDARGS=
# github.com/docker/compose/v5/pkg/dryrun
vendor/github.com/docker/compose/v5/pkg/dryrun/dryrunclient.go:43:26: cannot use &DryRunClient{} (value of type *DryRunClient) as "github.com/moby/moby/client".APIClient value in variable declaration: *DryRunClient does not implement "github.com/moby/moby/client".APIClient (missing method ImageAttestations)
make: *** [Makefile:78: .gotmp/bin/linux_amd64/ddev] Error 1

We didn't run into this before because the Moby maintainers were always quick to release updates like this, but not this time:

Pulling it without more changes.

@stasadev
stasadev merged commit 5630dc9 into main Jun 19, 2026
55 of 58 checks passed
@stasadev
stasadev deleted the 20260618_stasadev_deps branch June 19, 2026 07:22
This was referenced Jun 19, 2026
Merged
Merged
Closed
@thaJeztah thaJeztah mentioned this pull request Jul 2, 2026
Merged
@chenrui333 chenrui333 mentioned this pull request Jul 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stasadev @rfay