build: update go deps, vendor docker-compose SDK, for #8234#8198
Merged
build: update go deps, vendor docker-compose SDK, for #8234#8198
Conversation
github-actions
Bot
added
dependencies
rfay
reviewed
Mar 4, 2026
This was referenced Mar 4, 2026
stasadev
force-pushed
the
20260303_stasadev_compose_and_buildx
branch
from
28ad57b to
32dc23b
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
stasadev
force-pushed
the
20260303_stasadev_compose_and_buildx
branch
2 times, most recently
from
5fefeb9 to
71f5166
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
stasadev
force-pushed
the
20260303_stasadev_compose_and_buildx
branch
from
71f5166 to
e01a845
Compare
|
Download the artifacts for this pull request:
See Testing a PR.
|
stasadev
force-pushed
the
20260303_stasadev_compose_and_buildx
branch
from
7331560 to
2333779
Compare
Member
Author
|
I'm going to convert this PR into one that bumps the We need to run tests on Windows, but this is a fork PR, and I need to know what happens in that case. |
stasadev
force-pushed
the
20260303_stasadev_compose_and_buildx
branch
6 times, most recently
from
20b0294 to
77cac45
Compare
stasadev
changed the title
stasadev
force-pushed
the
20260303_stasadev_compose_and_buildx
branch
from
335578e to
830501f
Compare
stasadev
force-pushed
the
20260303_stasadev_compose_and_buildx
branch
2 times, most recently
from
da927d0 to
410e7ce
Compare
stasadev
changed the title
stasadev
force-pushed
the
20260303_stasadev_compose_and_buildx
branch
from
410e7ce to
d12db66
Compare
stasadev
commented
Mar 17, 2026
Comment on lines
+20
to
+27
| // For new Docker Compose SDK https://github.com/ddev/ddev/pull/8234 | ||
| import ( | ||
| _ "github.com/docker/cli/cli" | ||
| _ "github.com/docker/cli/cli/streams" | ||
| _ "github.com/docker/compose/v5/cmd/display" | ||
| _ "github.com/docker/compose/v5/pkg/api" | ||
| _ "github.com/docker/compose/v5/pkg/compose" | ||
| ) |
Member
Author
There was a problem hiding this comment.
My plan is to add new imports here in vendor PRs, and then remove them in the PRs where they are actually used.
This way, we can split the logic for easier review.
P.S. It was painful to write this comment because GitHub lags heavily with such a large PR.
rfay
approved these changes
Mar 18, 2026
Member
rfay
left a comment
rfay
left a comment
There was a problem hiding this comment.
Thanks, it looks quite safe. Nice work doing it this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
We need to bump dependecies:
We need to vendor docker-compose SDK for:
How This PR Solves The Issue
Bumps all vendor dependencies and adds a new SDK for docker-compose.
This is a separate PR, so #8234 will be easier to review once this is merged.
This PR adds two new files:
pkg/tools/tools.go, which can be used to import new libraries sogo mod tidydoes not complain.pkg/tools/doc.go, which is needed becausego testcomplains when a package has only build constraints, so this file was added.Manual Testing Instructions
Automated Testing Overview
Release/Deployment Notes