Conversation
|
Download the artifacts for this pull request:
See Testing a PR. |
Member
7c31cf8 to
2fe5c2d
Compare
2 tasks
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
6cd3be1 to
22ca621
Compare
Member
|
I fiddled slightly with docs and added a case to a test. I ran the full TestDdevAllDatabases and TestDdevImportDB and they were OK. Unfortunately, I can't seem to get this to work with the repro case in It seems like it's still broken. I experimented with several |
Member
Author
That repro case is incorrect, because the example file has -sed -e 's/utf8_general_ci/utf8mb4_0900_ai_ci/' .ddev/mysql/character-set.cnf.example > .ddev/mysql/character-set.cnf
+cat > .ddev/mysql/collation-server.cnf <<EOF
+[mysqld]
+collation-server = utf8mb4_0900_ai_ci
+EOFcat > .ddev/mysql/collation-server.cnf <<EOF
[mysqld]
collation-server = utf8mb4_0900_ai_ci
EOFSee the manual instructions in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Previous behavior: The import logic replaced modern collations (
utf8mb4_0900_ai_cifrom MySQL 8.0+ andutf8mb4_uca1400_ai_cifrom MariaDB 11.x) with a hardcoded fallback ofutf8mb4_unicode_ci.New behavior: Before importing, we now query the database server's default collation using
SELECT @@collation_serverand use that value as the replacement target. This respects the actual server configuration instead of assuming a specific collation.This PR:
collation_server = utf8mb4_0900_ai_ci), the import will now preserve those collations instead of forcing a downgrade to an older collation. This gives users control over their collation.Manual Testing Instructions
From #8130:
The same can be repeated for
mysql:5.7ormariadb:11.8ormariadb:10.5:You shouldn't see illegal mix of collations in the browser.
And repeat the same thing in the same project, but this time with
utf8mb4_0900_ai_ciin MySQL 8.0 (ddev launchshows a mixed collation with DDEV v1.25.0):Automated Testing Overview
Release/Deployment Notes