docs: update Windows installation docs to use 'Docker Engine' terminology #7092
Conversation
Use official 'Docker Engine' terminology rather than 'Docker CE'.
Amend link
Nick-Hope
changed the title
Nick-Hope
changed the title
|
Thanks for this thoughtful contribution! Your point is valid, but of course you'll note that the actual installation is One reason we use "Docker CE" is that they use "docker engine" for any Docker Desktop usage, including on macOS and Windows. Other Docker Providers don't use "engine" even though that's what they are too. Let's continue the conversation. We don't want to confuse people, but also Docker's terminology isn't perfect. What do you think about just adding a note about what "Docker CE" is (The open-source Community Edition of the Docker Engine) ? |
| @@ -149,7 +149,7 @@ Once you’ve [installed a Docker provider](docker-installation.md), you’re re | |||
|
|
|||
| You can install DDEV on Windows three ways: | |||
|
|
|||
| 1. [Using WSL2 with Docker inside](#wsl2-docker-ce-inside-install-script) **Recommended, best performance, most reliable** | |||
| 1. [Using WSL2 with Docker Engine](#wsl2-docker-engine-install-script) **Recommended, best performance, most reliable** | |||
There was a problem hiding this comment.
"Docker inside" is in fact very poor usage here, and we can do better. "Docker Engine" isn't great, because it allows confusion with Docker Desktop, which also has "Docker Engine" in it.
| @@ -182,9 +182,9 @@ Once you’ve [installed a Docker provider](docker-installation.md), you’re re | |||
| * Installing DDEV inside your distro; this is normally done by running one of the two scripts below, but can be done manually step-by-step as well. | |||
| * Verify that your distro uses WSL version 2 with `wsl.exe -l -v`. | |||
|
|
|||
| ### WSL2 + Docker CE Inside Install Script | |||
| ### WSL2 + Docker Engine Install Script | |||
There was a problem hiding this comment.
I think "Docker CE" rather than "Docker CE Inside" might be better.
| @@ -109,13 +109,13 @@ You’ll need a Docker provider on your system before you can [install DDEV](dde | |||
|
|
|||
| ## Windows | |||
|
|
|||
| If you’re working inside WSL2, which we recommend, you can [install Docker Engine (docker-ce) inside of it](#docker-ce-inside-windows-wsl2). Otherwise, you can [install Docker Desktop](#docker-desktop-for-windows), which works with both traditional Windows and WSL2. | |||
| If you’re working inside WSL2, which we recommend, you can [install Docker Engine (docker-ce) inside of it](#docker-engine-inside-windows-wsl2). Otherwise, you can [install Docker Desktop](#docker-desktop-for-windows), which works with both traditional Windows and WSL2. | |||
There was a problem hiding this comment.
This one is OK, although can use more standardization.
Revert proposed changes from "Docker CE" to "Docker Engine" but clarify terminology.
Revert proposed changes from "Docker CE" to "Docker Engine" but clarify terminology.
|
@rfay It is difficult because "Docker CE" doesn't really seem to have a home on the web under that name. A Google for "Docker CE" takes you to https://docs.docker.com/engine/install/, which does refer to it as "Docker Engine on Linux, also known as Docker CE". Anyway, I have reverted back to "Docker CE", added clarification about what it is in both documents, and cleaned up a few bits and pieces. One subtle change is the lower case 'i' in the heading "WSL2 + Docker CE inside Install Script". I remember misguidedly searching for a product called 'Docker CE Inside' at one point. "But shouldn't you be doing the Linux instructions at the same time, since Docker CE in WSL2 is almost completely the same thing as the Linux install." |
|
Thanks for the good thinking on this! It is a problem, and glad to see it get some cleaning action. |
|
|
||
| This technique is our favorite, as it uses the most reliable WSL2 Docker provider (`docker-ce`), which is also free and open-source. | ||
| This technique is our favorite, as it uses the most reliable WSL2 Docker provider, Docker CE - the free, open-source Community Edition of [Docker Engine](https://docs.docker.com/engine/). |
The Issue
The documents for Docker Installation and DDEV Installation refer to "Docker CE". While the package name is still
docker-ce, the official name is now 'Docker Engine' (see https://docs.docker.com/engine/). This can be particularly confusing to a newcomer, puzzled by the various terminology for Docker implementation.How This PR Solves The Issue
Changes the name from 'Docker CE' to 'Docker Engine' and updates links where necessary.
Review at https://ddev--7092.org.readthedocs.build/en/7092/users/install/ddev-installation/#ddev-installation-windows
Release/Deployment Notes
Any external links direct to the heading anchors within the page will be affected. If the PR is merged, I will personally update the link on Drupal documentation from https://www.drupal.org/docs/develop/local-server-setup/windows-development-environment/installing-drupal-with-ddev-in-wsl2-on-windows/installing-docker-ddev-drupal-in-wsl2.