Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix secret loading [skip buildkite] #7090

Merged
merged 3 commits into from
Mar 14, 2025
Merged

test: Fix secret loading [skip buildkite] #7090

merged 3 commits into from
Mar 14, 2025

Conversation

rfay
Copy link
Member

@rfay rfay commented Mar 14, 2025

The Issue

Trying again here with @stasadev technique.

@rfay rfay changed the title test: Fix secret loading test: Fix secret loading [skip buildkite] Mar 14, 2025
stasadev
stasadev approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see Authenticated with Service account.

@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:

See Testing a PR.

Open in GitHub Codespaces

@rfay rfay marked this pull request as ready for review March 14, 2025 18:31
@rfay rfay requested a review from a team as a code owner March 14, 2025 18:31
@rfay rfay merged commit 41fdace into main Mar 14, 2025
27 of 29 checks passed
@rfay rfay deleted the 20250314_rfay_fix_secret_loading branch March 14, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stasadev stasadev stasadev approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfay @stasadev