test: don't load 1password secrets if not available [skip buildkite] #7088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasadev
changed the title
|
Download the artifacts for this pull request:
See Testing a PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Dependabot PRs and some forked PRs fail in some places where they could continue without secrets.
Instead, this PR attempts to check if the base
secrets.TESTS_SERVICE_ACCOUNT_TOKENis available, and if it is not, then proceed without loading 1password secrets.I'm not sure this PR will actually use the changes added here, but recreated this on upstream to give it the best chance to see.