Wow!

This change also needs an update to the global schema.json

(I will test edge cases later today.)

Old approach doesn't work for me.
(I don't see any records when I refresh the page.)

ddev config global --xhprof-mode-reset && ddev restart && ddev xhprof && ddev launch /xhprof

(Not important) I noticed some inconsistency in --xhprof-mode-reset (it may also exist in another -reset flag):

ddev config global --xhprof-mode=xhgui
ddev config --xhprof-mode=prepend

# doesn't reset .ddev/config.yaml
ddev config --xhprof-mode-reset

# but this works
ddev config --xhprof-mode=""

Tested on ddev version v1.24.3-95-g915cd248b.

• ✅ ddev xhgui asks to add global configuration

  • Manually remove xhprof-mode from global config

  $ ddev xhgui
  XHProf Mode is set to 'prepend', can't use 'ddev xhgui'.
  Use the command below to enable it:
  ddev config global --xhprof-mode=xhgui && ddev restart

• ✅ ddev config global --xhprof-mode=xhgui updates config

  $ ddev config global --xhprof-mode=xhgui && ddev restart
  ...
  Your project can be reached at https://lara11-base-demo.ddev.site

• ✅ ddev xhgui on starts debugging, confirmed with ddev xhgui launch

  $ ddev xhgui                                            
   Container ddev-lara11-base-demo-xhgui  Created 
   Container ddev-lara11-base-demo-xhgui  Started 
  Started optional compose profiles 'xhgui' 
  Enabled XHProf for XHGui. 

• ✅ ddev xhgui status correctly reports on

  $ ddev xhgui status
  XHProf is enabled and capturing performance information. 
  The XHGui service is running and you can access it at https://lara11-base-demo.ddev.site:8142 

• ✅ ddev xhgui off and am no longer able to access website via ddev xhgui lanuch

  $ ddev xhgui off 
  $ ddev xhgui status
  XHProf is disabled. 
  XHGui is disabled. 

• ✅ delete project database, changed to Postgres 16 and correctly ran ddev xhgui launch

  $ ddev delete -Oy
  $ ddev config --project-type=php --database=postgres:16
  $ ddev xhgui

• ✅ ddev xhgui -h and ddev xhgui --help both correctly display help messgae

  $ ddev xhgui
  ddev xhgui -h    
    Starts or checks status of XHGui/XHProf performance monitoring and UI.
    You can use 'ddev xhgui on' to enable, 'ddev xhgui' or 'ddev xhgui launch' to view the UI.
    'ddev xhgui status' shows the status.
  ...

• ✅ ddev xhgui -j does nothing (previously opened browser)

• Install ddev/ddev-xhgui and then ddev start to see removal
• Validate that xhprof still works with xhprof-mode=prepend
• tested it with mysql:8.4
• tested it without db container, seeing an expected error on ddev xhgui

My nitpicks:

• We should have a named volume for xhgui Dockerfile has an unnamed volume for /run/nginx perftools/xhgui#505

• The xhgui image is pulled up during the first ddev start, which may slow down some CI tests, but on the other hand, people may see it and wonder "What is this new image? What does it do?" and start using it, which can give us more feedback on ddev xhgui

• The port configuration can only be done with manual editing for .ddev/config.yaml, I don't expect people will use this often, so not asking for new flags in ddev config

• Testing without router worked only when I added host_xhgui_port: 8142, without it opens the main website (the host port is not assigned automatically, I don't see it in the ddev describe),

• Not related to this PR, but without router ddev mailpit opens http://127.0.0.1:8025, and not the actual port from ddev describe