Skip to content

Conversation

@rocketeerbkw
Copy link
Contributor

The Issue

A recent lagoon-cli release enabled strict host key checking for ssh by default uselagoon/lagoon-cli#370

How This PR Solves The Issue

Adding a flag to disable this option for the test automation.

Manual Testing Instructions

Automated Testing Overview

Fixes existing tests.

Release/Deployment Notes

A recent lagoon-cli release enabled strict host key checking for ssh by default uselagoon/lagoon-cli#370
@rocketeerbkw rocketeerbkw requested a review from a team as a code owner September 4, 2024 15:44
@github-actions github-actions bot added the bugfix label Sep 4, 2024
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks!

@github-actions
Copy link

github-actions bot commented Sep 4, 2024

@rfay rfay self-requested a review September 4, 2024 16:29
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing shows the problem still happening. @rocketeerbkw is going to roll a new lagoon client, so we'll need to build a new ddev-webserver as normal.

@rfay rfay changed the title fix: Lagoon integration automated tests test: Lagoon integration automated tests Sep 4, 2024
@rfay
Copy link
Member

rfay commented Sep 5, 2024

Closing in favor of #6526 , which is same code but on not-forked PR so can actually run TestLagoonPush.

@rfay rfay closed this Sep 5, 2024
rfay added a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants