Merged
Conversation
There used to be a bug in the Moby terminal escape proxy: moby/moby#39728 Since it is now fixed upstream, we can remove the patched version from the codebase. Additionally, this narrows down the Moby dependency to moby/term instead of the broad moby/moby package.
bamarni
requested review from
armandgrillet,
drewvanstone and
janisz
as code owners
Collaborator
|
Can one of the admins verify this patch? |
2 similar comments
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
Can one of the admins verify this patch? |
Contributor
|
We need to wait until we fix our CI |
janisz
approved these changes
Apr 17, 2020
drewvanstone
approved these changes
Apr 20, 2020
armandgrillet
approved these changes
Apr 20, 2020
Contributor
|
@mesosphere-ci run all integration tests |
1 similar comment
Contributor
|
@mesosphere-ci run all integration tests |
Contributor
|
@mesosphere-ci run all integration tests |
Contributor
|
@mesosphere-ci run linux integration tests |
1 similar comment
Contributor
|
@mesosphere-ci run linux integration tests |
Contributor
|
@bamarni thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There used to be a bug in the Moby terminal escape proxy:
moby/moby#39728
Since it is now fixed upstream, we can remove the patched version from
the codebase.
Additionally, this narrows down the Moby dependency to moby/term
instead of the broad moby/moby package.