Repository navigation
Don't let asyncio.run() shut down the DBOS executor - #925
Merged
kraftp merged 3 commits intoOct 27, 2026
Merged
Conversation
kraftp
approved these changes
Oct 27, 2026
kraftp
left a comment
Member
There was a problem hiding this comment.
This looks good, thanks for the fix!
Contributor
Author
|
The 3.14 / Postgres failure is test_cancel_resume_queue (assert 3 == 2), which looks flaky on main. I ran it 40 times on Python 3.14 against Postgres: without this change, it failed once with the same assertion; with this change, 0 of 40. Could you re-run that job? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #924
Description of the fix
Calling a DBOS async API from an event loop that DBOS doesn't own, like asyncio.run(), shuts down the DBOS executor when that loop closes. After that, every start_workflow and queue dispatch raised "cannot schedule new futures after shutdown" until the process restarted.
Implementation
_configure_asyncio_thread_pool() sets the DBOS executor itself as the running loop's default executor, and asyncio.run() calls shutdown() on that executor on exit. Now the loop gets a small ThreadPoolExecutor subclass that submits to the DBOS executor and ignores shutdown(). It has to be a subclass because set_default_executor() only accepts a ThreadPoolExecutor. It's created once per executor and reused, and DBOS.destroy() still shuts down the real executor like before.
Testing