Add postgres to the Travis CI build#558
Conversation
javornikolov
force-pushed
the
topic/add-postgres-to-travis-ci
branch
2 times, most recently
from
8fef786 to
1b0b7e0
Compare
build.gradle
Outdated
| fastbuild, | ||
| ':dbfit-java:db2:integrationTest', | ||
| ':dbfit-java:mysql:integrationTest', | ||
| ':dbfit-java:postgres:integrationTest', |
There was a problem hiding this comment.
Any particular reason for running before Oracle?
There was a problem hiding this comment.
Not really a great reason. I'll change the order.
|
Looks good. Can we merge this before getting the tests passing though? |
javornikolov
force-pushed
the
topic/add-postgres-to-travis-ci
branch
from
1b0b7e0 to
c392aff
Compare
Good that you asked since I already got wondering about how to fix the tests. However I already have enough confidence that this PR is working fine (it fires up the postgresql tests) - perhaps no reason to wait further. What do you think? |
| @@ -0,0 +1,8 @@ | |||
| CREATE TABLE IF NOT EXISTS changelog ( | |||
There was a problem hiding this comment.
Perhaps that script can be reused from the postgres Chef recipe to avoid duplication.
|
I think merging it allows us to address the broken tests more easily. So +1.
…Sent from my iPhone
On 18 Mar 2017, at 15:19, Yavor Nikolov <[email protected]<mailto:[email protected]>> wrote:
Looks good. Can we merge this before getting the tests passing though?
Good that you asked since I already got wondering about how to fix the tests. However I already have enough confidence that this PR is working fine (it fires up the postgresql tests) - perhaps no reason to wait further. What do you think?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#558 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABztFXDuDyQGFstIJwqkDuppceoZ0tv_ks5rm_X8gaJpZM4Mhbfa>.
|
Extract posgresql test-schema objects setup into a separate sql script in order to be able to reuse it outside the chef recipe
javornikolov
force-pushed
the
topic/add-postgres-to-travis-ci
branch
from
e50796d to
c5ece27
Compare
|
I just did some refactoring and force pushed-it - to keep the schema objects setup in a single place ( 0f26a09) |
|
As we've recently done for DB2 and Oracle, should we move other files from |
|
|
|
Here b76b7cc I committed an experiment with gradle I'm not quite sure if that feature is already done (https://discuss.gradle.org/t/new-feature-continue-execution-on-task-failure/7604) since I thing it doesn't have effect on our project. |
|
I think it's a good thing to have for the future. It could certainly speed up fixes to build failures.
…Sent from my iPhone
On 18 Mar 2017, at 16:42, Yavor Nikolov <[email protected]<mailto:[email protected]>> wrote:
Here b76b7cc<b76b7cc> I committed an experiment with gradle --continue option. We may move it to another PR if we'd like to keep it. The intent is to see that other integration tests are green even in case of postgres failure here.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#558 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABztFTMx_grksK1D4E3skT3xabrhenoaks5rnAlbgaJpZM4Mhbfa>.
|
javornikolov
force-pushed
the
topic/add-postgres-to-travis-ci
branch
from
b76b7cc to
c5ece27
Compare
2 participants
Add postgresql to the Travis CI environment and include postgres integration tests to the Travis build.