Skip to content

test_vm: migrate from Librarian-Chef to Berkshelf#516

Merged
javornikolov merged 1 commit intomasterfrom
topic/testvm-migrate-librarian-chef-to-berkshelf
Oct 23, 2016
Merged

test_vm: migrate from Librarian-Chef to Berkshelf#516
javornikolov merged 1 commit intomasterfrom
topic/testvm-migrate-librarian-chef-to-berkshelf

Conversation

@javornikolov
Copy link
Copy Markdown
Contributor

@javornikolov javornikolov commented Oct 23, 2016

  • migrate test VM cookbook management from librarian-chef to
    berkshelf as vagrant-librarian-chef plugin is not supported
    any more
  • postgresql dependency version is set to >= 4 in order to
    get priority over openssl (otherwise Berkshelf picks a lower
    version of postgresql in favour of higher one for openssl)

@javornikolov
test_vm: migrate from librarian chef to berkshelf
8754120 
* Migrate test VM cookbook management from librarian-chef to
  berkshelf as vagrant-librarian-chef plugin is not supported
  any more
* Set postgresql dependency >= 4 in order to get priority over
  openssl. Otherwise Berkshelf picks a lower version of postgresql
  in favour of higher one for openssl
@javornikolov
Copy link
Copy Markdown
Contributor Author

javornikolov commented Oct 23, 2016

Functionally this should behave identically - just the cookbooks are maintained elsewhere (the folders are not under the project). At first glimpse the cookbooks are downloaded a bit faster with Berkshelf and with a bit more detailed logging.

@MMatten
Copy link
Copy Markdown
Contributor

MMatten commented Oct 23, 2016

Looks great.

I don't quite understand the comment about postgres vs OpenSSL. Can you explain again?

@javornikolov
Copy link
Copy Markdown
Contributor Author

javornikolov commented Oct 23, 2016 •
edited
Loading

I don't quite understand the comment about postgres vs OpenSSL. Can you explain again?

The latest 4.x version of postgresql is not compatible with latest version of openssl 6.x. So the highest-possible-version method for selecting cookbook versions is not deterministic: it could be either postgresql 3.x and openssl 6.x or postgresql 4.x and openssl 4.x. Librarian-chef used to pick the latter option but Berkshelf - the former one. By adding the version constraint for postgresql I managed to make this choice more deterministic (and postgresql is more important to us than openssl).

@MMatten
Copy link
Copy Markdown
Contributor

MMatten commented Oct 23, 2016

Got it. Looks good to me.

It will be good to move onto a new supported toy (Berkshelf) :)

@javornikolov
Copy link
Copy Markdown
Contributor Author

javornikolov commented Oct 23, 2016

Cool. I'm merging...

@javornikolov javornikolov merged commit b7cac78 into master Oct 23, 2016
@javornikolov javornikolov deleted the topic/testvm-migrate-librarian-chef-to-berkshelf branch October 23, 2016 20:35
@javornikolov javornikolov added this to the 4.0.0 milestone Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

techdebt

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@javornikolov @MMatten