Skip to content

Use CoreTests suite in Derby Flow and Standalone mode tests#371

Merged
javornikolov merged 1 commit intomasterfrom
coretest-for-derby
May 28, 2015
Merged

Use CoreTests suite in Derby Flow and Standalone mode tests#371
javornikolov merged 1 commit intomasterfrom
coretest-for-derby

Conversation

@MMatten
Copy link
Copy Markdown
Contributor

@MMatten MMatten commented May 25, 2015

Enhance test coverage for Derby and progress work on simplifying acceptance tests (issue #23).

javornikolov
javornikolov reviewed May 25, 2015
View reviewed changes
Comment thread FitNesseRoot/DbFit/AcceptanceTests/JavaTests/DerbyTests/FlowMode/SetUp/content.txt
Copy link
Copy Markdown
Contributor

@javornikolov javornikolov May 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that Commit necessary here?

Copy link
Copy Markdown
Contributor Author

@MMatten MMatten May 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the Commit here to simulate having a permanent table in a DB where the structure (DDL) is persisted rather than created for each test.

This is to enable the tests, that include the slightly irregular TransactionsTest, to run properly. TransactionsTest includes a Commit and this makes commits the DDL and so the next test fails because of the Execute Ddl in the SetUp.

The Rollback in the TearDown undoes the DML that's executed in the test as would normally happen at the end of a flow mode test.

I then need to drop the DB objects and commit that drops so that any subsequent test's SetUp will run correctly.

It might be better to do something with the TransactionsTest test but I'm not sure what.

Copy link
Copy Markdown
Contributor

@javornikolov javornikolov May 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it's fine as is. I was just curious.

@javornikolov
Copy link
Copy Markdown
Contributor

javornikolov commented May 26, 2015

👍 Looks OK to me now.

@MMatten
Copy link
Copy Markdown
Contributor Author

MMatten commented May 26, 2015

Cool. I thought the new test classes JAR task could be a point of discussion as it sets a convention. Have you guys done something similar before?

@javornikolov
Copy link
Copy Markdown
Contributor

javornikolov commented May 26, 2015

The int-tests jar is indeed something I stared at for a while to figure out what it's doing. A bit similar thing is what we've done with copyExtraLibs.
One observation is that now we end up with several empty jars (just MANIFEST inside); and the derby one only has a real class file inside.

@MMatten
Copy link
Copy Markdown
Contributor Author

MMatten commented May 27, 2015

Just checking situation with the integration test JARs again. I can only see one for Derby (dbfit-derby-integration-test-3.1.0.jar) when I run ./gradlew starthere so I guess it's only producing an archive if there is at least one class file produced (with Support in the class name).

javornikolov
javornikolov reviewed May 27, 2015
View reviewed changes
Comment thread build.gradle Outdated
Copy link
Copy Markdown
Contributor

@javornikolov javornikolov May 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is trailing whitespace here.

@javornikolov
Copy link
Copy Markdown
Contributor

javornikolov commented May 27, 2015

Just checking situation with the integration test JARs again. I can only see one for Derby (dbfit-derby-integration-test-3.1.0.jar) when I run ./gradlew starthere so I guess it's only producing an archive if there is at least one class file produced (with Support in the class name).

When I tested I ran ./gradlew integrationTestJar which explains why I got it for all projects: the copyTestLibs task invokes the derby part only.

Let's fix the trailing whitespace and squash the commits into one: then we can merge.

@MMatten MMatten force-pushed the coretest-for-derby branch from 93ce9e4 to 1cee8f8 Compare May 28, 2015 17:58
@MMatten
Copy link
Copy Markdown
Contributor Author

MMatten commented May 28, 2015

Whitespace removed and fix-ups squashed.

@MMatten
Copy link
Copy Markdown
Contributor Author

MMatten commented May 28, 2015

Ah, I guess I still need to rebase first.

@MMatten MMatten force-pushed the coretest-for-derby branch from 1cee8f8 to fc079b2 Compare May 28, 2015 18:58
javornikolov added a commit that referenced this pull request May 28, 2015
@javornikolov
Merge pull request #371 from dbfit/coretest-for-derby
3a5beb0 
Use CoreTests suite in Derby Flow and Standalone mode tests
@javornikolov javornikolov merged commit 3a5beb0 into master May 28, 2015
@javornikolov javornikolov deleted the coretest-for-derby branch May 28, 2015 20:13
@MMatten MMatten mentioned this pull request Jul 5, 2015
Merged
3 tasks
@javornikolov javornikolov added this to the 3.2.0 milestone Aug 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

techdebt

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@MMatten @javornikolov