Support case sensitive collation object names in SQL Server#362
Support case sensitive collation object names in SQL Server#362javornikolov merged 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Why do we need a link to DisabledTests?
There was a problem hiding this comment.
This is so the DisabledTests suite is visible under the JavaTests suite else they're invisible unless you visit the DotNetTests suite.
Do you think this is the wrong thing to do? I thought I would be another reminder to get them working some time!
There was a problem hiding this comment.
OK. It's not wrong, I was just curious.
|
Thank you, @MMatten! In general looks good. I added a few minor remarks. Have you tested that for both case-sensitive and non-case sensitive database? |
|
Yes tests pass using both collation sequence I'll work on the above points. Thanks for the quick review. |
|
I think all of the points have been addressed now. Could you review again? |
There was a problem hiding this comment.
Trailing whitespace here and on a few other places.
Thanks! There is some trailing whitespace in |
|
I can see the trailing spaces but I can't see any |
There was a problem hiding this comment.
One more trailing space here.
I can't see CR either - seems OK now. Just one more space-only line remains. |
|
Found the blighter. It was a single tab on the line. |
|
I'm going to be away now until Monday so I'm going to, optimistically, squash the commits and push again. |
Great! I was just going to ask for squashing the whitespace re-formatting and other fixes and we're ready to merge then :-) |
MMatten
force-pushed
the
fix-sqlserver-case-sensitive-object-names
branch
from
466d3d8 to
e798dd4
Compare
To support transformations like: (a, b, c) -> [a].[b].[c]
…t-names Support case sensitive collation object names in SQL Server
2 participants
Support case sensitive/insensitive collations.
Remove redundant StandAlone mode regression test call.
Tidy and complete DB setup scripts.
Support 3 part table/view/procedure names.