Skip to content

DbFit build/test: add support for Oracle connection customization#338

Merged
benilovj merged 1 commit intomasterfrom
build-oracle-connection-customization
Sep 4, 2014
Merged

DbFit build/test: add support for Oracle connection customization#338
benilovj merged 1 commit intomasterfrom
build-oracle-connection-customization

Conversation

@javornikolov
Copy link
Copy Markdown
Contributor

This is to allow running DbFit acceptance tests with a non-default Oracle instance

@javornikolov javornikolov force-pushed the build-oracle-connection-customization branch from 29ae28e to 4eacc99 Compare September 3, 2014 21:03
@benilovj
Copy link
Copy Markdown
Member

benilovj commented Sep 4, 2014

This looks good, although is it not better for the default TestDbConnectionDbFitOracle.properties to live somewhere in the oracle folder rather than in a folder off the root?

@javornikolov javornikolov force-pushed the build-oracle-connection-customization branch from 4eacc99 to d0f2b72 Compare September 4, 2014 22:49
@javornikolov javornikolov force-pushed the build-oracle-connection-customization branch from d0f2b72 to 43a2602 Compare September 4, 2014 22:51
@javornikolov
Copy link
Copy Markdown
Contributor Author

This looks good, although is it not better for the default TestDbConnectionDbFitOracle.properties to live somewhere in the oracle folder rather than in a folder off the root?

I moved the oracle-specific connection defaults into oracle folder and rebased the branch.

benilovj added a commit that referenced this pull request Sep 4, 2014
DbFit build/test: add support for Oracle connection customization
@benilovj benilovj merged commit 2c9ce41 into master Sep 4, 2014
@benilovj benilovj deleted the build-oracle-connection-customization branch September 4, 2014 23:49
@javornikolov javornikolov modified the milestone: Next Release Sep 6, 2014
This was referenced Sep 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants