Scale independence when comparing decimal numbers#261
Merged
Conversation
Examining decimals with various scales
Member
|
is this ready to go? |
Contributor
Author
|
Yes. |
benilovj
added a commit
that referenced
this pull request
Mar 24, 2014
…endence Scale independence when comparing decimal numbers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #260
Maybe in general it would be better for cases like that to inject some kind of comparator/matcher instead of mutating the data type. But that would be a more involved change so leaving it for future consideration.