Merged
Conversation
(Exposing milliseconds of java.sql.Time in #toString)
Remove some duplicated code
(Otherwise some precision is getting lost. Time is not supported before SQL Server 2008 - SQL Server is supposed to ignore this param for earlier versions)
Member
|
This looks really good. I guess you tested it against a real SQL Server instance? |
Contributor
Author
|
Yes, I managed to run it on SQL Server Express Edition 2014. |
Member
|
ok great. |
benilovj
added a commit
that referenced
this pull request
Mar 17, 2014
MS SQL Server TIME type support
benilovj
changed the title
benilovj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #242 - support has been added for
TIMEdata type for MS SQL Server