Skip to content

Commit d4b1c9d

Browse files
committed
Point web hyphens TODOs at flutter#193506
Web rendering of soft hyphens is now tracked separately so this PR can close flutter#18443 for native platforms.
1 parent 893b54e commit d4b1c9d

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎engine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/text.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ class CkParagraphStyle implements ui.ParagraphStyle {
8282
// Neither Hyphens.manual nor Hyphens.hidden takes effect on CanvasKit until a
8383
// renderSoftHyphens setter is exposed on the CanvasKit ParagraphStyle binding
8484
// (the native engine wires this via SkParagraph::setRenderSoftHyphens).
85-
// https://github.com/flutter/flutter/issues/18443
85+
// https://github.com/flutter/flutter/issues/193506
8686
// Customizing the hyphen string is separate future work:
8787
// https://github.com/flutter/flutter/issues/189617
8888
final ui.Hyphens? _hyphens;

‎engine/src/flutter/lib/web_ui/lib/src/engine/skwasm/skwasm_impl/paragraph.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -841,7 +841,7 @@ class SkwasmParagraphStyle implements ui.ParagraphStyle {
841841
// Neither Hyphens.manual nor Hyphens.hidden takes effect on Skwasm until a
842842
// renderSoftHyphens setter is exposed on the Skwasm ParagraphStyle binding
843843
// (the native engine wires this via SkParagraph::setRenderSoftHyphens).
844-
// https://github.com/flutter/flutter/issues/18443
844+
// https://github.com/flutter/flutter/issues/193506
845845
// Customizing the hyphen string is separate future work:
846846
// https://github.com/flutter/flutter/issues/189617
847847
final ui.Hyphens? _hyphens;

‎engine/src/flutter/lib/web_ui/lib/src/engine/web_paragraph/paragraph.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class WebParagraphStyle implements ui.ParagraphStyle {
6363

6464
// TODO(dbebawy): honor hyphens in the pure-Dart line-breaker/painter (no
6565
// soft-hyphen glyph emitted at a break yet). Accepted and stored for now.
66-
// https://github.com/flutter/flutter/issues/18443
66+
// https://github.com/flutter/flutter/issues/193506
6767
final ui.Hyphens? hyphens;
6868

6969
WebStrutStyle? get strutStyle => _strutStyle;

0 commit comments

Comments
 (0)