Repository navigation
Fix vertical table alignment for Unicode headers - #117
Merged
rolandwalker merged 1 commit intoOct 16, 2026
Merged
Conversation
Contributor
|
Thanks! Makes sense! Any reason this PR is still a draft? |
Rajvira10
marked this pull request as ready for review
October 16, 2026 15:38
rolandwalker
approved these changes
Oct 16, 2026
Contributor
|
Thank you! |
3 tasks done
Merged
3 of 4 tasks
j-bennet
pushed a commit
to dbcli/pgcli
that referenced
this pull request
Nov 3, 2026
cli_helpers 2.15.2, released 2026-10-16, aligns vertical output by display width (dbcli/cli_helpers#117), so the header 配列, two wide characters, gets two fewer padding spaces. The test had the old misalignment written down and fails with the new release. The expectation now has the aligned output, and cli_helpers >= 2.15.2 keeps the test from depending on which release is installed: 2.15.1 fails it, as it should, since it misaligns. Co-authored-by: Diego <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Vertical output misaligns headers such as
名前andagebecause padding counts characters rather than terminal columns. Measure visible width before padding, including styled headers.Three regression cases fail before the fix. Full suite: 92 passed, 4 skipped; without styling: 86 passed, 10 skipped.
Black ran directly because the hook configuration requires unavailable Python 3.7.
Checklist
CHANGELOG.AUTHORSfile.blackon my code.