Add lint script for bad case on "Datadog"#98
Merged
ErikBoesen merged 3 commits intomainfrom Sep 25, 2022
Merged
Conversation
ErikBoesen
approved these changes
Sep 25, 2022
Collaborator
ErikBoesen
left a comment
ErikBoesen
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Mr0grog
added a commit
that referenced
this pull request
Sep 26, 2022
As a followup to #98, rename `DataDogReporter` to `DatadogReporter` (no capital "D" in the middle). I didn't add a deprecation warning here because we haven't yet had a release that exposes this class publicly, so nobody could have been using it before.
Mr0grog
added a commit
that referenced
this pull request
Sep 26, 2022
As a followup to #98, rename `DataDogReporter` to `DatadogReporter` (no capital "D" in the middle). I didn't add a deprecation warning here because we haven't yet had a release that exposes this class publicly, so nobody could have been using it before.
Mr0grog
added a commit
that referenced
this pull request
Feb 9, 2023
As a followup to #98, rename `DataDogReporter` to `DatadogReporter` (no capital "D" in the middle). I didn't add a deprecation warning here because we haven't yet had a release that exposes this class publicly, so nobody could have been using it before.
Mr0grog
added a commit
that referenced
this pull request
Feb 21, 2023
…100) The `apiHost` property here is the same as what Datadog’s docs refer to `site`, so we’ve renamed it to match. We’ve also lower-cased the second "d" in `DatadogReporter`, since the previous spelling was wrong (see #59 and #98 for more about that). Both of the old names still work, but using them prints deprecation warnings to let users know they should update their code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #59, @dbenamy fixed a number of places where the text "DataDog" (incorrect) was used instead of "Datadog" (correct). People have since added more incorrect usages (many from me!), so this adds a quick script to log an error during linting to prevent re-introducing the problem.
It outputs something like (live example):
(Although hopefully on future PRs it will be shorter!)
Edit: fixed bad paste in example above.