Check that types are valid before publishing#130
Merged
Conversation
In #120, I added a test of our built types. Since we do a clean build of the types before publishing, we should also do a final check of those build results just to avoid any accidental issues for things that weren't fully checked (usually CI protects us here, but since we publish manually, a final check is useful!).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #120, I added a test of our built types. Since we do a clean build of the types before publishing, we should also do a final check of those build results just to avoid any accidental issues for things that weren't fully checked (usually CI protects us here, but since we publish manually, a final check is useful!).
I think this is pretty straightforward and I should have just done it as part of #120, so I’m going to go ahead and merge this tomorrow if there’s no feedback.