-
Notifications
You must be signed in to change notification settings - Fork 60
Comparing changes
Open a pull request
base repository: dbader/node-datadog-metrics
base: deede5d
head repository: dbader/node-datadog-metrics
compare: fac9ff7
- 15 commits
- 14 files changed
- 1 contributor
Commits on Oct 13, 2022
-
Build TypeScript types from doc comments
This converts a number of comments in the code to JSDoc-style comments (and adds some more detailed descriptions/types along the way) and uses TypeScript to build type definition files from the comments. This allows you to publish types directly from this package instead of making TypeScript user install `@types/datadog-metrics`, which is maintained separately, by hand, and won't always be up-to-date. It does not add new comments for objects that are not publicly exposed (although that would be a good idea for consistency). It also adds NPM lifecycle scripts to automatically build types when publishing. Fixes #86.
Configuration menu - View commit details
-
Copy full SHA for 8e72b16 - Browse repository at this point
Copy the full SHA 8e72b16View commit details -
This should help verify that most changes are valid.
Configuration menu - View commit details
-
Copy full SHA for 9f12ea0 - Browse repository at this point
Copy the full SHA 9f12ea0View commit details -
Convert public classes to ES6 class syntax
This updates the syntax for all the public classes (reporters, BufferedMertricsLogger) to use native `class` syntax. This allows TypeScript to build better type definitions (compare the output before and after this commit). It also makes for slightly more compact and easy-to-manage syntax. Partially fixes #83.
Configuration menu - View commit details
-
Copy full SHA for 902c77f - Browse repository at this point
Copy the full SHA 902c77fView commit details -
Use class syntax in rest of private code
This extends the previous change to use class syntax and JSDoc comments everywhere in the codebase. It also turns on type checking (which now works because we are using class syntax everywhere).
Configuration menu - View commit details
-
Copy full SHA for ac6ec4c - Browse repository at this point
Copy the full SHA ac6ec4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c325d4 - Browse repository at this point
Copy the full SHA 7c325d4View commit details -
The prepare script runs when installing, which causes errors when running tests, and means we see type errors multiple times over in CI. This moves it to prepack so it only runs when packing and/or publishing.
Configuration menu - View commit details
-
Copy full SHA for 7f1bb86 - Browse repository at this point
Copy the full SHA 7f1bb86View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3dc3e5 - Browse repository at this point
Copy the full SHA b3dc3e5View commit details -
Stop running tests twice on every PR push
This probably shouldn't have gotten in originally, but it's pretty noisy when all tests run twice when pushing new commits to a PR (once for the push event and once for the update to the PR).
Configuration menu - View commit details
-
Copy full SHA for 13b709b - Browse repository at this point
Copy the full SHA 13b709bView commit details -
Add release notes for #104 (#105)
I missed adding release notes in #104, so I'm adding them separately here. This also cleans up some extra blank lines from that change.
Configuration menu - View commit details
-
Copy full SHA for d5306dc - Browse repository at this point
Copy the full SHA d5306dcView commit details
Commits on Oct 15, 2022
-
Port updates from v0.10.x fork to main
Version 0.10.2 was just released with critical bugfixes, and this adds those updates to the `main` development branch (which has breaking changes and is focused on v0.11.0).
Configuration menu - View commit details
-
Copy full SHA for 2c4222c - Browse repository at this point
Copy the full SHA 2c4222cView commit details
Commits on Feb 21, 2023
-
Rename
apiHost→siteandDataDogReporter→DatadogReporter(#……100) The `apiHost` property here is the same as what Datadog’s docs refer to `site`, so we’ve renamed it to match. We’ve also lower-cased the second "d" in `DatadogReporter`, since the previous spelling was wrong (see #59 and #98 for more about that). Both of the old names still work, but using them prints deprecation warnings to let users know they should update their code.
Configuration menu - View commit details
-
Copy full SHA for 735b632 - Browse repository at this point
Copy the full SHA 735b632View commit details -
Document using a custom reporter
The proposed feature in #107 was withdrawn because the problem it was solving could have already been handled with a custom reporter. This adds some documentation about how to set up a custom reporter to prevent similar misunderstandings in the future.
Configuration menu - View commit details
-
Copy full SHA for 825e6b0 - Browse repository at this point
Copy the full SHA 825e6b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74fcb28 - Browse repository at this point
Copy the full SHA 74fcb28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ce4d51 - Browse repository at this point
Copy the full SHA 0ce4d51View commit details -
Do not publish
tsconfig.tsbuildinfoThis is a follow-on to #104. I missed that this file would get published, even though it should not be.
Configuration menu - View commit details
-
Copy full SHA for fac9ff7 - Browse repository at this point
Copy the full SHA fac9ff7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff deede5d...fac9ff7