Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dbader/node-datadog-metrics
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: deede5d
Choose a base ref
...
head repository: dbader/node-datadog-metrics
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fac9ff7
Choose a head ref
  • 15 commits
  • 14 files changed
  • 1 contributor

Commits on Oct 13, 2022

  1. Build TypeScript types from doc comments

    This converts a number of comments in the code to JSDoc-style comments (and adds some more detailed descriptions/types along the way) and uses TypeScript to build type definition files from the comments. This allows you to publish types directly from this package instead of making TypeScript user install `@types/datadog-metrics`, which is maintained separately, by hand, and won't always be up-to-date.
    
    It does not add new comments for objects that are not publicly exposed (although that would be a good idea for consistency). It also adds NPM lifecycle scripts to automatically build types when publishing.
    
    Fixes #86.
    Mr0grog authored and ErikBoesen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    8e72b16 View commit details
    Browse the repository at this point in the history
  2. Build types in CI

    This should help verify that most changes are valid.
    Mr0grog authored and ErikBoesen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    9f12ea0 View commit details
    Browse the repository at this point in the history
  3. Convert public classes to ES6 class syntax

    This updates the syntax for all the public classes (reporters, BufferedMertricsLogger) to use native `class` syntax. This allows TypeScript to build better type definitions (compare the output before and after this commit). It also makes for slightly more compact and easy-to-manage syntax.
    
    Partially fixes #83.
    Mr0grog authored and ErikBoesen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    902c77f View commit details
    Browse the repository at this point in the history
  4. Use class syntax in rest of private code

    This extends the previous change to use class syntax and JSDoc comments everywhere in the codebase. It also turns on type checking (which now works because we are using class syntax everywhere).
    Mr0grog authored and ErikBoesen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    ac6ec4c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7c325d4 View commit details
    Browse the repository at this point in the history
  6. Move build to prepack

    The prepare script runs when installing, which causes errors when running tests, and means we see type errors multiple times over in CI. This moves it to prepack so it only runs when packing and/or publishing.
    Mr0grog authored and ErikBoesen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    7f1bb86 View commit details
    Browse the repository at this point in the history
  7. Fix intentional error

    Mr0grog authored and ErikBoesen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    b3dc3e5 View commit details
    Browse the repository at this point in the history
  8. Stop running tests twice on every PR push

    This probably shouldn't have gotten in originally, but it's pretty noisy when all tests run twice when pushing new commits to a PR (once for the push event and once for the update to the PR).
    Mr0grog authored and ErikBoesen committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    13b709b View commit details
    Browse the repository at this point in the history
  9. Add release notes for #104 (#105)

    I missed adding release notes in #104, so I'm adding them separately here. This also cleans up some extra blank lines from that change.
    Mr0grog authored Oct 13, 2022
    Configuration menu
    Copy the full SHA
    d5306dc View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2022

  1. Port updates from v0.10.x fork to main

    Version 0.10.2 was just released with critical bugfixes, and this adds those updates to the `main` development branch (which has breaking changes and is focused on v0.11.0).
    Mr0grog committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    2c4222c View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Rename apiHost site and DataDogReporter DatadogReporter (#…

    …100)
    
    The `apiHost` property here is the same as what Datadog’s docs refer to `site`, so we’ve renamed it to match. We’ve also lower-cased the second "d" in `DatadogReporter`, since the previous spelling was wrong (see #59 and #98 for more about that).
    
    Both of the old names still work, but using them prints deprecation warnings to let users know they should update their code.
    Mr0grog authored Feb 21, 2023
    Configuration menu
    Copy the full SHA
    735b632 View commit details
    Browse the repository at this point in the history
  2. Document using a custom reporter

    The proposed feature in #107 was withdrawn because the problem it was solving could have already been handled with a custom reporter. This adds some documentation about how to set up a custom reporter to prevent similar misunderstandings in the future.
    Mr0grog authored and ErikBoesen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    825e6b0 View commit details
    Browse the repository at this point in the history
  3. Fix typo!

    Mr0grog authored and ErikBoesen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    74fcb28 View commit details
    Browse the repository at this point in the history
  4. Prepare v0.11.0 for release

    Mr0grog authored and ErikBoesen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    0ce4d51 View commit details
    Browse the repository at this point in the history
  5. Do not publish tsconfig.tsbuildinfo

    This is a follow-on to #104. I missed that this file would get published, even though it should not be.
    Mr0grog committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    fac9ff7 View commit details
    Browse the repository at this point in the history
Loading