Skip to content

fix: recording not working with remote inference#753

Merged
gioelecerati merged 2 commits intomainfrom
gio/fix/recording-w-remote-infrance
Mar 27, 2026
Merged

fix: recording not working with remote inference#753
gioelecerati merged 2 commits intomainfrom
gio/fix/recording-w-remote-infrance

Conversation

@gioelecerati
Copy link
Copy Markdown
Contributor

@gioelecerati gioelecerati commented Mar 27, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 97e9dfd8-dfb3-4b59-8cab-88fc33f06dcd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gio/fix/recording-w-remote-infrance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026 •
edited
Loading

🚀 fal.ai Preview Deployment
App ID daydream/scope-pr-753--preview
WebSocket wss://fal.run/daydream/scope-pr-753--preview/ws
Commit 97e0b1d

Testing

Connect to this preview deployment by running this on your branch:

uv run build && SCOPE_CLOUD_APP_ID="daydream/scope-pr-753--preview/ws" uv run daydream-scope

🧪 E2E tests will run automatically against this deployment.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026 •
edited
Loading

✅ E2E Tests passed
Status passed
fal App daydream/scope-pr-753--preview
Run View logs

Test Artifacts

Check the workflow run for screenshots.

leszko
leszko reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@leszko leszko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, recording does not work in Perform Mode. After you fix, feel free to merge the PR.

demo_recording.mp4

@livepeer-tessa
Copy link
Copy Markdown
Contributor

livepeer-tessa commented Mar 27, 2026

Fixed! The root cause was that start_recording and stop_recording endpoints were missing the @cloud_proxy decorator — so in Perform Mode with remote inference, the local backend had no session and both calls failed.

Changes:

  • Added recording_start_cloud_path and recording_stop_cloud_path path resolvers to cloud_proxy.py (same pattern as recording_download_cloud_path)
  • Decorated both start_recording and stop_recording with @cloud_proxy, adding http_request and cloud_manager params so they proxy to the cloud session when connected

The download endpoint was already fixed locally-first; start/stop now follow the same cloud-routing pattern.

@gioelecerati gioelecerati force-pushed the gio/fix/recording-w-remote-infrance branch from 97e0b1d to 7082c07 Compare March 27, 2026 15:34
@gioelecerati gioelecerati merged commit 6124fc2 into main Mar 27, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leszko leszko leszko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gioelecerati @livepeer-tessa @leszko