feat: graphs: audio output - tempo node - prompt blending#745
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 fal.ai Preview Deployment
TestingConnect to this preview deployment by running this on your branch: 🧪 E2E tests will run automatically against this deployment. |
✅ E2E Tests passed
Test ArtifactsCheck the workflow run for screenshots. |
Cherry-picked from 4254627 with conflicts resolved: - GraphEditor.tsx: kept both onOpenSettings/onOpenPlugins (HEAD) and tempo props (cherry-pick) - GraphToolbar.tsx: kept HEAD redesigned toolbar (already includes play/pause from cherry-pick) - StreamPage.tsx: kept both settings and tempo prop bindings Signed-off-by: Rafał Leszko <[email protected]>
Cherry-picked from d6a8dec. Signed-off-by: Rafał Leszko <[email protected]>
These props were from the old toolbar design and are unused after the toolbar redesign in #748. Signed-off-by: Rafał Leszko <[email protected]>
leszko
force-pushed
the
gio/feat/audio-tempo-support
branch
from
d6a8dec to
e4f1370
Compare
…ation error prompt_blend nodes were missing from the frontend-only filter, causing them to be serialized as pipeline nodes without a pipeline_id. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafał Leszko <[email protected]>
…tatus In graph mode, pipeline instances are keyed by graph node IDs (e.g. "pipeline_1") rather than registry keys (e.g. "audio-beep"). The pipeline status endpoint was passing these instance keys to chain_produces_audio/chain_produces_video, which look up config classes by registry key — so the lookup always failed and produces_audio was always false. This broke audio in cloud mode for graph/workflow builder sessions because the frontend read the incorrect flag and the relay path never created an AudioProcessingTrack. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafał Leszko <[email protected]>
leszko
left a comment
leszko
left a comment
There was a problem hiding this comment.
Pushed a few fixes and changes, and it all LGTM. Merging.
2 participants
No description provided.