feat: analytics opt in by hthillman · Pull Request #728 · daydreamlive/scope

hthillman · 2026-03-23T20:42:02Z

No description provided.

coderabbitai · 2026-03-23T20:42:09Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a2d9fab-4ddc-4507-a094-28f9dc35893a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch hunter/analytics-opt-out

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-03-23T20:49:08Z

🚀 fal.ai Preview Deployment


App ID	`daydream/scope-pr-728--preview`
WebSocket	`wss://fal.run/daydream/scope-pr-728--preview/ws`
Commit	`cb3076c`

Testing

Connect to this preview deployment by running this on your branch:

uv run build && SCOPE_CLOUD_APP_ID="daydream/scope-pr-728--preview/ws" uv run daydream-scope

🧪 E2E tests will run automatically against this deployment.

github-actions · 2026-03-23T20:52:27Z

❌ E2E Tests failed


Status	failed
fal App	`daydream/scope-pr-728--preview`
Run	View logs

Test Artifacts

Check the workflow run for screenshots, traces, and failure details.

livepeer-tessa · 2026-03-24T22:24:12Z

🔧 E2E build fix pushed

The E2E test was failing at "Build Scope app" due to TypeScript errors in 4 files unrelated to the analytics changes:

src/components/VideoOutput.tsx(139): error TS2322: Type 'Timeout' is not assignable to type 'number'
src/components/ui/debounced-slider.tsx(60): same
src/hooks/usePipeline.ts(110): same  
src/hooks/useWebRTCStats.ts(129): same (setInterval)

Root cause: posthog-js brings in @types/node transitively, which makes setTimeout/setInterval resolve to NodeJS.Timeout instead of number — breaking existing refs typed as useRef<number | null>.

Fix: Changed the 4 timer refs to use ReturnType<typeof setTimeout> / ReturnType<typeof setInterval>, which resolves correctly in both browser and Node.js environments. Committed as d57b627.

- Add onboarding flow for new users with fog-of-war background, Manrope font - Cloud onboarding: connecting step, auth redirect resume, graph import - Add API key warning to workflow import review screen - Replace starter workflow graphs with exported versions including tutorial notes - Add provenance to all starter workflow LoRAs for auto-download - Add Workflows tab to PluginsDialog, rename plugin to node in UI - Fix build errors after rebase, restore onboarding integration in StreamPage - Fix workflow graph import, pipeline availability in cloud mode - Fix e2e test: skip onboarding overlay in cloud streaming test Signed-off-by: Rafał Leszko <[email protected]> Signed-off-by: gioelecerati <[email protected]>

(cherry picked from commit af49522) Signed-off-by: gioelecerati <[email protected]>

- Telemetry disclosure is now the first question in cloud connecting flow, replacing "let's get to know each other" as the opener - "No thanks" skips full survey, goes straight to teaching/simple picker - "Yes" continues with normal survey flow - Added: node_removed, connection_removed, workflow_saved, user_logged_out, onboarding_workflow_download_failed events Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Hunter Hillman <[email protected]> Signed-off-by: gioelecerati <[email protected]>

#737) …oast - Add relative z-20 + pointer-events-auto to TelemetryDisclosure to fix clicks being blocked by backdrop-blur stacking context - Skip "let's get to know each other" intro after accepting telemetry by passing initialScreen="referral" to CloudSurveyScreens - Restore existing-user toast disclosure in TelemetryContext for users who completed onboarding before analytics was added Signed-off-by: Hunter Hillman <[email protected]> Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: gioelecerati <[email protected]>

Signed-off-by: gioelecerati <[email protected]>

gioelecerati

LGTM - removed some dead code on beacon events - which I think got imported via the analytics library we got to manage beforeunload events but it's not used here (and won't be)

leszko force-pushed the hunter/onboarding-flow branch from 6521512 to 2bcc925 Compare March 24, 2026 13:34

hthillman force-pushed the hunter/analytics-opt-out branch from 5503d6d to 49be9f9 Compare March 24, 2026 21:39

hthillman force-pushed the hunter/analytics-opt-out branch 2 times, most recently from d852d4a to af49522 Compare March 24, 2026 23:41

hthillman marked this pull request as ready for review March 25, 2026 00:20

leszko force-pushed the hunter/analytics-opt-out branch from e16cebe to 85df242 Compare March 25, 2026 14:00

leszko requested review from gioelecerati and leszko March 25, 2026 14:10

gioelecerati force-pushed the hunter/onboarding-flow branch from 5bbdb97 to 7bd153b Compare March 27, 2026 09:35

gioelecerati force-pushed the hunter/analytics-opt-out branch from 85df242 to 7872260 Compare March 27, 2026 13:16

gioelecerati changed the title ~~Hunter/analytics opt in~~ feat: analytics opt in Mar 27, 2026

gioelecerati changed the base branch from hunter/onboarding-flow to main March 27, 2026 13:19

leszko and others added 5 commits March 27, 2026 14:20

feat: add opt-in analytics with Mixpanel/PostHog provider abstraction

e41a05a

(cherry picked from commit af49522) Signed-off-by: gioelecerati <[email protected]>

prettier

cb3076c

Signed-off-by: gioelecerati <[email protected]>

gioelecerati force-pushed the hunter/analytics-opt-out branch from 7872260 to cb3076c Compare March 27, 2026 13:20

removed dead code sendBeacon

0817a6a

Signed-off-by: gioelecerati <[email protected]>

gioelecerati approved these changes Mar 27, 2026

View reviewed changes

gioelecerati merged commit 14a6a8e into main Mar 27, 2026
8 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: analytics opt in#728

feat: analytics opt in#728
gioelecerati merged 6 commits intomainfrom
hunter/analytics-opt-out

hthillman commented Mar 23, 2026

Uh oh!

coderabbitai bot commented Mar 23, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

livepeer-tessa commented Mar 24, 2026

Uh oh!

gioelecerati left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hthillman commented Mar 23, 2026

Uh oh!

coderabbitai bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 fal.ai Preview Deployment

Testing

Uh oh!

github-actions bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ E2E Tests failed

Test Artifacts

Uh oh!

livepeer-tessa commented Mar 24, 2026

🔧 E2E build fix pushed

Uh oh!

gioelecerati left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Mar 23, 2026 •

edited

Loading

github-actions bot commented Mar 23, 2026 •

edited

Loading

github-actions bot commented Mar 23, 2026 •

edited

Loading