Flush audio buffer on prompt change for immediate TTS playback#719
Merged
Flush audio buffer on prompt change for immediate TTS playback#719
Conversation
When prompts change, drain the audio output queue and send a flush sentinel so the audio track discards buffered speech from the previous prompt. Also increases the max audio buffer to 60s for TTS pipelines and reduces the audio output queue size to 10 (since it's now flushed on prompt changes). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafal Leszko <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Contributor
🚀 fal.ai Preview Deployment
TestingConnect to this preview deployment by running this on your branch: 🧪 E2E tests will run automatically against this deployment. |
Contributor
✅ E2E Tests passed
Test ArtifactsCheck the workflow run for screenshots. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When prompts change, drain the audio output queue and send a flush sentinel so the audio track discards buffered speech from the previous prompt. Also increases the max audio buffer to 60s for TTS pipelines and reduces the audio output queue size to 10 (since it's now flushed on prompt changes).
For the context, I haven't yet decided if when we should flash audio. Maybe it's the UI that should decide (kind-of like cache reset), or maybe pipeline should return an information that the audio should be flushed. But for now, let's use the "workaround" to flush when there is a new prompt happening.