Skip to content

Fix: tempo sync modulation interfering with VACE noise scale.#716

Merged
leszko merged 1 commit intomainfrom
marco/fix/noise-scale
Mar 19, 2026
Merged

Fix: tempo sync modulation interfering with VACE noise scale.#716
leszko merged 1 commit intomainfrom
marco/fix/noise-scale

Conversation

@BuffMcBigHuge
Copy link
Copy Markdown
Collaborator

@BuffMcBigHuge BuffMcBigHuge commented Mar 18, 2026

#703 changed apply_mode_defaults_to_state to conditionally skip setting noise_scale and noise_controller to None in text mode:

// Before PR #703 (unconditional):
state.set("noise_scale", None)
state.set("noise_controller", None)

if mode == INPUT_MODE_TEXT:
    if "noise_scale" not in kwargs:
        state.set("noise_scale", None)
    if "noise_controller" not in kwargs:
        state.set("noise_controller", None)

This was done so the modulation engine could inject noise_scale into kwargs without it being overridden. However, it has a side effect that breaks VACE with video input.

@BuffMcBigHuge BuffMcBigHuge requested a review from leszko March 18, 2026 21:58
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 18, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ef3494a3-a174-4448-8e44-41a7d5ab4523

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch marco/fix/noise-scale
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 18, 2026

🚀 fal.ai Preview Deployment
App ID daydream/scope-pr-716--preview
WebSocket wss://fal.run/daydream/scope-pr-716--preview/ws
Commit d93e3d2

Testing

Connect to this preview deployment by running this on your branch:

uv run build && SCOPE_CLOUD_APP_ID="daydream/scope-pr-716--preview/ws" uv run daydream-scope

🧪 E2E tests will run automatically against this deployment.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 18, 2026

✅ E2E Tests passed
Status passed
fal App daydream/scope-pr-716--preview
Run View logs

Test Artifacts

Check the workflow run for screenshots.

@leszko leszko merged commit 92f8fba into main Mar 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leszko leszko leszko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BuffMcBigHuge @leszko