Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 fal.ai Preview Deployment
TestingConnect to this preview deployment by running this on your branch: 🧪 E2E tests will run automatically against this deployment. |
✅ E2E Tests passed
Test ArtifactsCheck the workflow run for screenshots. |
6c06866 to
93cda83
Compare
f88bb22 to
27c0870
Compare
211c580 to
81ac985
Compare
dcf827d to
0da42df
Compare
697d64c to
bdf92d6
Compare
6521512 to
2bcc925
Compare
The mythical-creature.webp asset was missing from frontend/public/assets/onboarding/, causing a broken image icon on the first workflow card in the onboarding picker. - Add placeholder thumbnail (replace with final art before merge) - Add onError handler to hide broken img element gracefully Fixes: #697 Signed-off-by: livepeer-robot <[email protected]>
Root cause found + fix pushedThe Mythical Creature card shows a broken image because What I pushed to the branch (efbc441)
To do before merge
|
leszko
left a comment
There was a problem hiding this comment.
Added a few comments, one more is that I think that if you run on Mac and select "Local" it would be nice to have some non-gpu-friendly workflow to choose. E.g. kaleido-scope or a simple pipeline like gray. Just something that you can run on Mac.
Root cause + fix (659215b)Two bugs combined to make the Remote Inference toggle unclickable after cloud onboarding: 1.
|
|
@leszko addressed almost all of the comments - I will handle the workflow connections (Dissolving cat) when we finalize the workflows. |
There was a problem hiding this comment.
@hthillman I pushed a few changes into your branch. Hope you don't mind. Other than that, added 2 inline comments. PTAL.
I think what's missing before merging this PR:
- You addressing these 2 comments
- Complete sample workflows (including Mac-friendly)
- Fix Electron App
- Testing more Workflow Builder and the decision to use it by default
- @gioelecerati addressing (some of) the missing features
| use_case: str | None = None | ||
|
|
||
|
|
||
| @app.get("/api/v1/onboarding/status", response_model=OnboardingStatusResponse) |
There was a problem hiding this comment.
@hthillman I wonder, wouldn't it be better to not store the info about the onboarding in the backend server, but rather store it in the frontend browser data? We currently do this for Graph caching, so when a user closes the app and opens again, they see the same graph as before. Wdyt?
There was a problem hiding this comment.
@leszko Would we ever want a user to see the onboarding again? what if browser data gets cleared?
There was a problem hiding this comment.
Showing onboarding again is a worse UX than the graph cache case, where re-showing a graph is often helpful
| nodeType: "lora", | ||
| loras: [ | ||
| { | ||
| path: "/tmp/.daydream-scope/assets/lora/diffslime_acidzlime-000016.safetensors", |
There was a problem hiding this comment.
This should not contain paths like this.
Also I wonder that maybe instead of hardcoding the workflows here, we should take them from https://app.daydream.live/ Wdyt?
There was a problem hiding this comment.
- we need the "teaching" workflows, which... I guess we could put on daydream.live?
- Whoops, nice catch
There was a problem hiding this comment.
My other worry about pulling from daydream.live - what if daydream.live is ever down? would that affect local experience?
- Add onboarding flow for new users with fog-of-war background, Manrope font - Cloud onboarding: connecting step, auth redirect resume, graph import - Add API key warning to workflow import review screen - Replace starter workflow graphs with exported versions including tutorial notes - Add provenance to all starter workflow LoRAs for auto-download - Add Workflows tab to PluginsDialog, rename plugin to node in UI - Fix build errors after rebase, restore onboarding integration in StreamPage - Fix workflow graph import, pipeline availability in cloud mode - Fix e2e test: skip onboarding overlay in cloud streaming test Signed-off-by: Rafał Leszko <[email protected]>
The mythical-creature.webp asset was missing from frontend/public/assets/onboarding/, causing a broken image icon on the first workflow card in the onboarding picker. - Add placeholder thumbnail (replace with final art before merge) - Add onError handler to hide broken img element gracefully Fixes: #697 Signed-off-by: livepeer-robot <[email protected]>
Two bugs prevented disconnecting after cloud onboarding: 1. useState(false) initial value — isSignedIn was false on the first render, making the toggle disabled until the useEffect fired. Fixed by using a lazy initialiser: useState(() => isAuthenticated()). 2. disabled condition checked !isSignedIn unconditionally — if isAuthenticated() returned false for any reason (env-key with no userId in localStorage, network hiccup during profile fetch, etc.) the toggle appeared green but was unclickable. Disconnecting cloud does not require authentication; only *connecting* does. Fixed by only gating on isSignedIn when the toggle action would trigger a connect (i.e. when currently disconnected). Also tightens the 'Log in required' hint so it only shows when the cloud is off and sign-in is actually needed. Signed-off-by: livepeer-robot <[email protected]>
…oltips - Add interstitial survey screens during cloud connecting (referral source, use case, onboarding style choice) that run concurrently with cloud relay - Add simple-mode starter workflows (Mythical Creature, Kubakub Butterfly, Pixel Art) with complete graph including source nodes and connections - Re-enable workspace tour with two-step tooltip flow: play button hint then workflows discovery, with text varying by onboarding style - Fix tour arrow positioning to point at actual anchor after viewport clamping - Tour waits for workflow import dialog to close before showing - Update Mythical Creature thumbnail image - Header: rename "Enable Remote Inference" to "Connect to Cloud", add Nodes/ Workflows/Settings buttons, fix Nodes button linking to wrong tab - Update inference mode descriptions for cloud and local options - Persist survey answers to backend onboarding.json Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Hunter Hillman <[email protected]>
When onboardingStyle is null (e.g. local mode), getWorkflowsForStyle was returning all 6 workflows (3 teaching + 3 simple), causing duplicates. Now defaults to "teaching" set. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Hunter Hillman <[email protected]>
Fix getDaydreamUserDisplayName being passed as a function reference instead of being called, extract duplicated activateCloudRelay into shared onboardingStorage module, and remove redundant inline json imports in app.py. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafal Leszko <[email protected]>
Add DAYDREAM_SCOPE_DIR env var and get_base_dir() to core/config.py so the onboarding file path is no longer hardcoded to ~/.daydream-scope. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafal Leszko <[email protected]>
Remove unused reducer actions (SELECT_WORKFLOW, START_DOWNLOADING, DOWNLOAD_FAILED, COMPLETE), dead state fields (selectedWorkflowId, downloadFailures), and unreachable phases (downloading, completed). Remove dead re-export in WorkflowPickerStep, console.log traces in GeneralTab, and simplify backend onboarding update with model_dump. Add missing hasFinePointer mobile guard to app FogOfWarBackground. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafal Leszko <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafał Leszko <[email protected]>
The WebGL fog-of-war component was duplicated nearly identically in both app/ and frontend/. Keep the frontend copy as the canonical source and import it into the Electron renderer via a @shared Vite alias, avoiding future drift between the two copies. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafał Leszko <[email protected]>
Use bare filenames instead of full /tmp/.daydream-scope/assets/lora/ paths in ui_state LoRA nodes. LoraNode auto-resolves filenames to full paths via resolveLoRAPath() at runtime. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Hunter Hillman <[email protected]>
- Replace Cyborg with Paint Blobs (BlobMe workflow with acid slime LoRA) - Replace Kubakub Butterfly with Dissolving Sunflower (depth + dissolve) - Paint Blobs teaching note mentions changing source to Camera - Add starter workflows chip on canvas showing untried workflow thumbnail - Add "Getting Started" section in Workflows tab with all starter workflows - Workflows tab and chip always show simple-mode workflows (no teaching notes) - New thumbnail images for Paint Blobs and Dissolving Sunflower Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Hunter Hillman <[email protected]>
The @shared alias imports FogOfWarBackground from frontend/src/, but its React imports resolved to frontend/node_modules/react (19.1.1) instead of app/node_modules/react (19.2.0). Two React instances in one tree causes an Invalid Hook Call error caught by the ErrorBoundary. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafał Leszko <[email protected]>
The record node was present in all 6 starter workflows but had no edge connecting it to the video stream. Added stream:video edges from the last pipeline node (rife or pipeline) to the record node. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafal Leszko <[email protected]>
- Add Camera Preview workflow for local mode (passthrough pipeline, no GPU required) with note about 24GB VRAM requirement and Cloud recommendation - WorkflowPickerStep shows local-only workflows when inferenceMode is local, with adjusted heading/description and single-card layout - Add back button to all onboarding steps (except first) with proper phase transitions through the flow - Fix fog-of-war background not showing on Windows touchscreen laptops: use "any-pointer: fine" instead of "pointer: fine" so a connected mouse is detected even when primary pointer is touch Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Hunter Hillman <[email protected]>
- Survey screens now have internal back button to navigate between steps - Pressing back on intro screen bubbles up to cloud_auth phase - Overlay back button hidden during cloud_connecting (survey handles it) - Camera Preview workflow shown as additional 4th option when running locally, alongside the normal teaching/simple workflows - Grid adapts to 4 columns when 4 workflows are present Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Hunter Hillman <[email protected]>
- Widen container to max-w-5xl when 4+ workflows shown so cards don't get too tall - Swap Camera Preview workflow data with exported camera_check.json (record node connected to output, proper positions) - Show camera icon on slate gradient background when thumbnail is empty Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Hunter Hillman <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Hunter Hillman <[email protected]>
Check hardware info when in local mode — show GPU-requiring workflows only when a GPU is detected, otherwise show only Camera Preview. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Rafał Leszko <[email protected]>
Add data-tour attributes to the redesigned toolbar for onboarding popovers, rename Plugins menu item to Nodes, add Default Workflow menu item with confirmation dialog, prevent text selection on toolbar buttons, and update starter workflow notes to reference the Run button in the upper right corner. Signed-off-by: gioelecerati <[email protected]> Made-with: Cursor
5bbdb97 to
7bd153b
Compare





Summary
GET/PUT /api/v1/onboarding/statuswith dual localStorage + API file storage layerdata-tourattribute anchoring system with custom portal-based tour popover (avoids focus-trap conflicts with graph canvas)Remaining TODOs
Test plan
~/.daydream-scope/onboarding.json) sees full onboarding flownpm run build)🤖 Generated with Claude Code