Skip to content

fix: displaying new loading text#659

Merged
mjh1 merged 1 commit intomainfrom
mh/fix-loading-text
Mar 12, 2026
Merged

fix: displaying new loading text#659
mjh1 merged 1 commit intomainfrom
mh/fix-loading-text

Conversation

@mjh1
Copy link
Copy Markdown
Contributor

@mjh1 mjh1 commented Mar 11, 2026 •
edited by coderabbitai bot
Loading

When backend progress updates were introduced here it seems we missed passing the properties through to the VideoOutput component, maybe something got messed up in a merge or something.

Verified working:
Screenshot 2026-03-11 at 11 08 46

Summary by CodeRabbit

  • New Features
    • Enhanced visibility into cloud connection and pipeline loading stages within the video interface, enabling better real-time status feedback.

@mjh1 mjh1 changed the title Fix displaying new loading text fix: displaying new loading text Mar 11, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 11, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8d3feb26-beb3-4f9a-910c-946c3bff7b3f

📥 Commits

Reviewing files that changed from the base of the PR and between 4cba0a9 and 185579f.

📒 Files selected for processing (1)
  • frontend/src/pages/StreamPage.tsx
📝 Walkthrough

Walkthrough

Added new state variables cloudConnectStage and pipelineLoadingStage to StreamPage component and forwarded them as props to the VideoOutput component, enabling child components to track backend cloud connection and pipeline loading progress.

Changes

Cohort / File(s) Summary
State Forwarding
frontend/src/pages/StreamPage.tsx		 Destructured cloudConnectStage from useCloudStatus() and pipelineLoadingStage from usePipeline(), then passed both as props to the VideoOutput component to expose loading and connectivity state to child components.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Props flowing down, like streams so clear,
Loading stages for all to hear,
Cloud connections dance on by,
Pipeline progress reaches the sky!
Simple forwarding, elegant and bright! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is directly related to the main change: forwarding loading state properties to display new loading text in the UI.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mh/fix-loading-text

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2026

🚀 fal.ai Preview Deployment
App ID daydream/scope-pr-659--preview
WebSocket wss://fal.run/daydream/scope-pr-659--preview/ws
Commit 185579f

Testing

Connect to this preview deployment by running this on your branch:

uv run build && SCOPE_CLOUD_APP_ID="daydream/scope-pr-659--preview/ws" uv run daydream-scope

🧪 E2E tests will run automatically against this deployment.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2026

✅ E2E Tests passed
Status passed
fal App daydream/scope-pr-659--preview
Run View logs

Test Artifacts

Check the workflow run for screenshots.

@mjh1 mjh1 requested review from emranemran and leszko March 11, 2026 12:05
@mjh1 mjh1 merged commit 853a23a into main Mar 12, 2026
10 checks passed
@mjh1 mjh1 deleted the mh/fix-loading-text branch March 12, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leszko leszko leszko approved these changes

@emranemran emranemran Awaiting requested review from emranemran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mjh1 @leszko