Conversation
🚀 fal.ai Preview Deployment
TestingConnect to this preview deployment by running this on your branch: 🧪 E2E tests will run automatically against this deployment. |
❌ E2E Tests failed
Test ArtifactsCheck the workflow run for screenshots, traces, and failure details. |
mjh1
force-pushed
the
mh/cloud-workflow
branch
3 times, most recently
from
70d109c to
9c21411
Compare
Signed-off-by: Max Holland <[email protected]>
Signed-off-by: Max Holland <[email protected]>
Signed-off-by: Max Holland <[email protected]>
Signed-off-by: Max Holland <[email protected]>
Signed-off-by: Max Holland <[email protected]>
Signed-off-by: Max Holland <[email protected]>
Signed-off-by: Max Holland <[email protected]>
Signed-off-by: Max Holland <[email protected]>
| echo "Deploying PR #${PR_NUMBER} to fal as ${APP_NAME}" | ||
|
|
||
| SCOPE_DEPLOY_TAG=$SHORT_SHA fal deploy \ | ||
| fal deploy \ |
There was a problem hiding this comment.
tidied this up, it can just get the tag based on the checked out version itself
| workflow: WorkflowRequest, | ||
| plugin_manager: PluginManager, | ||
| models_dir: Path, | ||
| lora_dir: Path, |
There was a problem hiding this comment.
in cloud we have loras stored separate to models so that they're not shared between users, so we need to use get_lora_dir() instead of models_dir / "lora"
| lora_dir = get_lora_dir() | ||
| try: | ||
| return await download_lora(request, lora_dir) | ||
| return await download_lora(request, lora_dir, civitai_token=civitai_token) |
There was a problem hiding this comment.
@ryanontheinside @leszko Not sure how you feel about doing it this way but in cloud mode I needed some way of passing the token from the user to the remote server, so it gets added to the request that gets proxied above in the if cloud_manager.is_connected: block, then it gets passed into download_lora here so that it can override get_civitai_token() on the remote side which will return nothing (we only store the api keys locally and send them along with the requests when they're proxied to remote).
Signed-off-by: Max Holland <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Rafał Leszko <[email protected]>
leszko
left a comment
leszko
left a comment
There was a problem hiding this comment.
Pushed one small refactor. Other than that, LGTM.
2 participants
Proxy new API calls to cloud to enable new workflow import/export