Make Syphon input discovery more reliable#544
Merged
Conversation
gioelecerati
approved these changes
Feb 26, 2026
leszko
requested changes
Feb 26, 2026
src/scope/server/app.py
Outdated
Comment on lines
+328
to
+334
| len( | ||
| __import__("objc") | ||
| .lookUpClass("SyphonServerDirectory") | ||
| .sharedDirectory() | ||
| .servers() | ||
| or [] | ||
| ), |
Collaborator
There was a problem hiding this comment.
This is weird, if that's so difficult to get the n of servers, then maybe just log without the number of servers?
Signed-off-by: Thom Shutt <[email protected]>
Signed-off-by: Thom Shutt <[email protected]>
Signed-off-by: Thom Shutt <[email protected]>
Signed-off-by: Thom Shutt <[email protected]>
Signed-off-by: Thom Shutt <[email protected]>
thomshutt
force-pushed
the
fix-syphon-discovery
branch
from
45bf421 to
b70e06e
Compare
Signed-off-by: Thom Shutt <[email protected]>
Signed-off-by: Rafał Leszko <[email protected]>
leszko
approved these changes
Feb 27, 2026
Collaborator
leszko
left a comment
leszko
left a comment
There was a problem hiding this comment.
I pushed a small refactor commit (renamed pump_run_loop()). Other than that LGTM. Merging.
Signed-off-by: Rafał Leszko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syphon server discovery relies on NSDistributedNotificationCenter, which delivers server announcement notifications exclusively to the main thread's NSRunLoop. In the FastAPI/uvicorn server, the main thread runs asyncio's event loop, so the NSRunLoop was never pumped. When ensure_directory_initialized() was called from a FastAPI worker thread, it pumped that worker thread's run loop instead — which receives zero notifications. This caused _get_raw_servers() to always return an empty list.