fix: prevent cloud connection inputMode reset and drop async from input source routes#460
Merged
fix: prevent cloud connection inputMode reset and drop async from input source routes#460
Conversation
When cloud connects, refreshPipelineSchemas() creates a new pipelineSchemas object reference. The inputMode effect watched this dependency and unconditionally reset inputMode to the pipeline default, overwriting the user's selection (e.g. "video" snapped back to "text"). Use a ref to track the previous pipelineId so the effect only resets inputMode when the pipeline actually changes, not on every schema refresh. Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Yondon Fu <[email protected]>
Signed-off-by: Yondon Fu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refreshPipelineSchemas()creates a newpipelineSchemasobject reference. An effect inuseStreamState.tswatched this dependency and unconditionally resetinputModeto the pipeline's default, overwriting the user's selection (e.g. "video" snapped back to "text"). Added auseRefto track the previouspipelineIdso the effect only resetsinputModewhen the pipeline actually changes.list_input_sources,get_input_source_resolution,get_input_source_preview) were declaredasyncbut perform blocking I/O. Removingasynclets FastAPI run them in a threadpool, preventing them from blocking the event loop.Test plan
🤖 Generated with Claude Code