feat: ndi output support & ndi live preview#457
Merged
gioelecerati merged 8 commits intomainfrom Feb 16, 2026
Merged
Conversation
gioelecerati
force-pushed
the
gio/feat/ndi-output
branch
from
6b2f9a3 to
3b29bf3
Compare
gioelecerati
changed the title
leszko
requested changes
Feb 13, 2026
Collaborator
leszko
left a comment
leszko
left a comment
There was a problem hiding this comment.
Reviewed the backend part. And tested. Looks good 🚀
Main points that I don't like:
app.pyusing frame processor to get input frames; I think this is too hacky for what we want to do 🙃- Lagacy spout stuff in schema.py and frame_processor.py; my thinking is that we don't need it and that now there should be no notion of spout.
I'd love to do another review on Monday, but if you're in rush, then always Yondon is the answer!
gioelecerati
force-pushed
the
gio/feat/ndi-output
branch
from
9fdc154 to
edfe99b
Compare
Signed-off-by: gioelecerati <[email protected]>
Signed-off-by: gioelecerati <[email protected]>
Signed-off-by: gioelecerati <[email protected]>
gioelecerati
force-pushed
the
gio/feat/ndi-output
branch
from
edfe99b to
f1d5250
Compare
Signed-off-by: gioelecerati <[email protected]>
leszko
approved these changes
Feb 16, 2026
Collaborator
leszko
left a comment
leszko
left a comment
There was a problem hiding this comment.
Added 2 comments. Other than that LGTM 👍 Great work @gioelecerati 🎉
One thing you can just double-check is if you enable both NDI in and NDI out. If it works smoothly and it the resources it consumes look ok. Saying that, because I was mainly testing it on a Windows TensorDock machine and at some point it performed very poorly. Then, after the machine restart it was good again. So, I'd assume it's related to TensorDock stability. But worth double-checking.
Signed-off-by: gioelecerati <[email protected]>
Signed-off-by: gioelecerati <[email protected]>
Signed-off-by: gioelecerati <[email protected]>
Signed-off-by: gioelecerati <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OutputSink->OutputSinksto allow having both Spout and NDI producing outputs in separate threads