fix(ci): skip postinstall script when updating app lock file#453
Merged
fix(ci): skip postinstall script when updating app lock file#453
Conversation
The app/ postinstall script (electron-builder install-app-deps) fails during `npm install --package-lock-only` because node_modules aren't installed. Adding --ignore-scripts skips lifecycle scripts since we only need the lock file updated. Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Yondon Fu <[email protected]>
yondonfu
force-pushed
the
ci/version-bump-workflows
branch
from
2ec5979 to
c475bb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ignore-scriptstonpm install --package-lock-onlyfor theapp/lock file update in the version-bump workflowapp/package.jsonpostinstall script (npx electron-builder install-app-deps) fails when nonode_modulesare present, which is the case during a lock-file-only installTest plan
version-bump.ymlworkflow and verify the app lock file step succeeds🤖 Generated with Claude Code