Conversation
Signed-off-by: Max Holland <[email protected]>
leszko
approved these changes
Feb 12, 2026
Collaborator
leszko
left a comment
leszko
left a comment
There was a problem hiding this comment.
Looks good. But something to consider either in this PR or in a follow-up is to wrap these connection_id, connection_info, user_id into a dict() (or a pydentic object). To avoid modifying sooo many files for such a simple change.
Signed-off-by: Max Holland <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses request from Evan to add user_id field to remaining kafka events.