Conversation
leszko
approved these changes
Feb 12, 2026
Collaborator
leszko
left a comment
leszko
left a comment
There was a problem hiding this comment.
Added some comments. Other than that, LGTM 👍
|
|
||
| // Track cloud connection state and clear images when it changes | ||
| // (switching between local/cloud means different asset lists) | ||
| const { isConnected: isCloudConnected, isConnecting: isCloudConnecting } = |
Collaborator
There was a problem hiding this comment.
Do we need this isCloudConnecting, It's not checked anywhere and it seems it could be enough to have isCloudConnected.
Contributor
Author
There was a problem hiding this comment.
Good spot, yep that shouldn't be needed
| } | ||
|
|
||
| prevCloudConnectedRef.current = isCloudConnected; | ||
| }, [isCloudConnected, isOpen]); |
Collaborator
There was a problem hiding this comment.
Shouldn't you add loadImages in the dependency array?
Fix the situation where we might reference local image paths on the cloud server, we now clear previously selected images on cloud connection state change and make sure to refresh the list in the image picker dynamically when the connection state changes rather than only when opening the picker Signed-off-by: Max Holland <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the situation where we might reference local image paths on the cloud server, we now: