Conversation
mjh1
force-pushed
the
mh/close-none
branch
2 times, most recently
from
e6e09d3 to
bd62873
Compare
leszko
reviewed
Feb 11, 2026
src/scope/server/tracks.py
Outdated
| self.frame_processor.stop() | ||
|
|
||
| await super().stop() | ||
| # MediaStreamTrack.stop() may be sync or async depending on aiortc version |
Collaborator
There was a problem hiding this comment.
Shouldn't we instead of handling both aiortc versions, jus pin to the specific aiortc version?
Contributor
Author
There was a problem hiding this comment.
I don't know if we want to pin the exact version just for this? We have aiortc>=1.13.0 set right now. Is there some static analysis tool we can run to check it? Anyways, I've removed the extra check and just made it work with the version we're on.
Signed-off-by: Max Holland <[email protected]>
mjh1
commented
Feb 11, 2026
| # This determines whether we wait for video frames or generate immediately. | ||
| self._video_mode = (initial_parameters or {}).get("input_mode") == "video" | ||
|
|
||
| # Pipeline chaining support (local mode only) |
Contributor
Author
There was a problem hiding this comment.
I verified this works for remote inference 👍
leszko
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The culprit ended up being:
scope/src/scope/server/tracks.py
Line 188 in 6d504dc
This was not an async function so await was returning
object NoneType can't be used in 'await' expression