feat: support all vace combinations#388
Merged
ryanontheinside merged 4 commits intomainfrom Feb 12, 2026
Merged
Conversation
Signed-off-by: RyanOnTheInside <[email protected]>
leszko
requested changes
Feb 10, 2026
Collaborator
leszko
left a comment
leszko
left a comment
There was a problem hiding this comment.
Thanks for the PR @ryanontheinside
Looks good in general. Added some comments. Also when you add the missing test files, I'll play with it more.
…ation, move test fixtures Signed-off-by: RyanOnTheInside <[email protected]>
Signed-off-by: RyanOnTheInside <[email protected]>
leszko
approved these changes
Feb 11, 2026
Collaborator
leszko
left a comment
leszko
left a comment
There was a problem hiding this comment.
Added one comment. Other than that, LGTM 👍
Signed-off-by: RyanOnTheInside <[email protected]>
yondonfu
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for combinations of VACE features. This is backwards compatible, and assuming we add masking plugins and chaining preprocessors, it should be automagically supported by the front end.