@@ -24,6 +24,66 @@ Offset globalize(Offset point, RenderBox box) {
2424 return box.localToGlobal (point);
2525}
2626
27+ // Drag-selects past the edge of a ListView nested in a PageView along [axis],
28+ // and checks the ListView edge scrolls while the PageView stays on its page.
29+ Future <void > selectPastNestedListEdge (WidgetTester tester, Axis axis) async {
30+ final pageController = PageController ();
31+ addTearDown (pageController.dispose);
32+ final listController = ScrollController ();
33+ addTearDown (listController.dispose);
34+ await tester.pumpWidget (
35+ TestWidgetsApp (
36+ home: SelectableRegion (
37+ selectionControls: testTextSelectionHandleControls,
38+ child: PageView (
39+ scrollDirection: axis,
40+ controller: pageController,
41+ children: < Widget > [
42+ ListView .builder (
43+ scrollDirection: axis,
44+ controller: listController,
45+ itemCount: 100 ,
46+ itemBuilder: (BuildContext context, int index) {
47+ return Center (child: Text ('Item $index ' ));
48+ },
49+ ),
50+ const Center (child: Text ('Second page' )),
51+ ],
52+ ),
53+ ),
54+ ),
55+ );
56+ await tester.pumpAndSettle ();
57+ expect (pageController.page, 0.0 );
58+ expect (listController.offset, 0.0 );
59+
60+ final RenderParagraph item0 = tester.renderObject <RenderParagraph >(
61+ find.descendant (of: find.text ('Item 0' ), matching: find.byType (RichText )),
62+ );
63+ final Rect box = tester.getRect (find.byType (PageView ));
64+ final target = axis == Axis .vertical
65+ ? Offset (box.center.dx, box.bottom + 40.0 )
66+ : Offset (box.right + 40.0 , box.center.dy);
67+
68+ final TestGesture gesture = await tester.startGesture (
69+ textOffsetToPosition (item0, 2 ),
70+ kind: PointerDeviceKind .mouse,
71+ );
72+ addTearDown (gesture.removePointer);
73+ await tester.pump ();
74+ await gesture.moveTo (target);
75+ await tester.pump ();
76+ await tester.pump (const Duration (seconds: 1 ));
77+
78+ // The inner ListView edge scrolled, but the PageView did not flip pages.
79+ expect (listController.offset, greaterThan (0.0 ));
80+ expect (pageController.page, 0.0 );
81+ expect (tester.takeException (), isNull);
82+
83+ await gesture.up ();
84+ await tester.pumpAndSettle ();
85+ }
86+
2787void main () {
2888 TestWidgetsFlutterBinding .ensureInitialized ();
2989 final mockClipboard = MockClipboard ();
@@ -1499,6 +1559,117 @@ void main() {
14991559 expect (tester.takeException (), isNull);
15001560 });
15011561
1562+ testWidgets (
1563+ 'paged scrollable does not flip pages during selection, but text still gets selected' ,
1564+ (WidgetTester tester) async {
1565+ final controller = PageController ();
1566+ addTearDown (controller.dispose);
1567+ await tester.pumpWidget (
1568+ TestWidgetsApp (
1569+ home: SelectableRegion (
1570+ selectionControls: testTextSelectionHandleControls,
1571+ child: PageView .builder (
1572+ controller: controller,
1573+ itemCount: 5 ,
1574+ itemBuilder: (BuildContext context, int index) {
1575+ return Center (child: Text ('Page $index ' ));
1576+ },
1577+ ),
1578+ ),
1579+ ),
1580+ );
1581+ await tester.pumpAndSettle ();
1582+ expect (controller.page, 0.0 );
1583+
1584+ final RenderParagraph page0 = tester.renderObject <RenderParagraph >(
1585+ find.descendant (of: find.text ('Page 0' ), matching: find.byType (RichText )),
1586+ );
1587+ final TestGesture gesture = await tester.startGesture (
1588+ tester.getCenter (find.text ('Page 0' )),
1589+ kind: ui.PointerDeviceKind .mouse,
1590+ );
1591+ addTearDown (gesture.removePointer);
1592+ await tester.pump ();
1593+ expect (controller.page, 0.0 );
1594+
1595+ // Hold the drag past the right edge; without the fix this keeps flipping
1596+ // pages toward page 1.
1597+ await gesture.moveTo (tester.getBottomRight (find.byType (PageView )) + const Offset (40.0 , 0.0 ));
1598+ await tester.pump ();
1599+ await tester.pump (const Duration (seconds: 1 ));
1600+
1601+ // The page did not flip, but the page's text was still selected.
1602+ expect (controller.page, 0.0 );
1603+ expect (page0.selections, isNotEmpty);
1604+ expect (tester.takeException (), isNull);
1605+
1606+ await gesture.up ();
1607+ await tester.pumpAndSettle ();
1608+ expect (controller.page, 0.0 );
1609+ expect (tester.takeException (), isNull);
1610+ },
1611+ );
1612+
1613+ testWidgets ('mouse selection drag still edge auto-scrolls a non page-snapping scrollable' , (
1614+ WidgetTester tester,
1615+ ) async {
1616+ // Counterpart to the PageView test above: only paged scrollables are
1617+ // affected. A plain ListView still edge scrolls while drag-selecting.
1618+ final controller = ScrollController ();
1619+ addTearDown (controller.dispose);
1620+ await tester.pumpWidget (
1621+ TestWidgetsApp (
1622+ home: SelectableRegion (
1623+ selectionControls: testTextSelectionHandleControls,
1624+ child: ListView .builder (
1625+ controller: controller,
1626+ scrollDirection: Axis .horizontal,
1627+ itemCount: 100 ,
1628+ itemBuilder: (BuildContext context, int index) {
1629+ return Center (child: Text ('Item $index ' ));
1630+ },
1631+ ),
1632+ ),
1633+ ),
1634+ );
1635+ await tester.pumpAndSettle ();
1636+ expect (controller.offset, 0.0 );
1637+
1638+ final RenderParagraph paragraph0 = tester.renderObject <RenderParagraph >(
1639+ find.descendant (of: find.text ('Item 0' ), matching: find.byType (RichText )),
1640+ );
1641+ final TestGesture gesture = await tester.startGesture (
1642+ textOffsetToPosition (paragraph0, 2 ),
1643+ kind: ui.PointerDeviceKind .mouse,
1644+ );
1645+ addTearDown (gesture.removePointer);
1646+ await tester.pump ();
1647+ expect (controller.offset, 0.0 );
1648+
1649+ // Drag past the right edge to kick off auto-scroll.
1650+ await gesture.moveTo (tester.getBottomRight (find.byType (ListView )) + const Offset (40.0 , 0.0 ));
1651+ await tester.pump ();
1652+ await tester.pump (const Duration (seconds: 1 ));
1653+ expect (controller.offset, greaterThan (0.0 ));
1654+ expect (tester.takeException (), isNull);
1655+
1656+ await gesture.up ();
1657+ await tester.pumpAndSettle ();
1658+ expect (tester.takeException (), isNull);
1659+ });
1660+
1661+ testWidgets ('vertical ListView inside a PageView still edge scrolls during selection' , (
1662+ WidgetTester tester,
1663+ ) async {
1664+ await selectPastNestedListEdge (tester, Axis .vertical);
1665+ });
1666+
1667+ testWidgets ('horizontal ListView inside a PageView still edge scrolls during selection' , (
1668+ WidgetTester tester,
1669+ ) async {
1670+ await selectPastNestedListEdge (tester, Axis .horizontal);
1671+ });
1672+
15021673 group ('Complex cases' , () {
15031674 testWidgets ('selection starts outside of the scrollable' , (WidgetTester tester) async {
15041675 final controller = ScrollController ();
0 commit comments