Skip to content

Commit a70227d

Browse files
committed
Guard _compareScreenOrder against unlaid-out selectables
When _RenderTheater skips layout for an obscured OverlayEntry (e.g., a non-current route behind an opaque route), selectables in that entry remain registered with their SelectionContainerDelegate. When _flushAdditions runs the sort via _compareScreenOrder, it accesses paintBounds/getTransformTo on RenderBoxes that have no size, throwing StateError in release mode and AssertionError in debug mode. This change wraps the geometry access in _compareScreenOrder with a try/catch that returns 0 (equal ordering) for unlaid-out selectables. Both _compareScreenOrder methods are guarded: - MultiSelectableSelectionContainerDelegate (selectable_region.dart) - _SelectableTextContainerDelegate (text.dart) They will be properly positioned on the next frame when layout completes. Fixes flutter#151536
1 parent ef87dc1 commit a70227d

4 files changed

Lines changed: 132 additions & 12 deletions

File tree

‎packages/flutter/lib/src/widgets/selectable_region.dart‎

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2576,13 +2576,27 @@ abstract class MultiSelectableSelectionContainerDelegate extends SelectionContai
25762576
Comparator<Selectable> get compareOrder => _compareScreenOrder;
25772577

25782578
static int _compareScreenOrder(Selectable a, Selectable b) {
2579-
final Rect rectA = MatrixUtils.transformRect(a.getTransformTo(null), _getBoundingBox(a));
2580-
final Rect rectB = MatrixUtils.transformRect(b.getTransformTo(null), _getBoundingBox(b));
2581-
final int result = _compareVertically(rectA, rectB);
2582-
if (result != 0) {
2583-
return result;
2579+
try {
2580+
final Rect rectA = MatrixUtils.transformRect(a.getTransformTo(null), _getBoundingBox(a));
2581+
final Rect rectB = MatrixUtils.transformRect(b.getTransformTo(null), _getBoundingBox(b));
2582+
final int result = _compareVertically(rectA, rectB);
2583+
if (result != 0) {
2584+
return result;
2585+
}
2586+
return _compareHorizontally(rectA, rectB);
2587+
} on StateError {
2588+
// In release mode, accessing `size` on an unlaid-out RenderBox throws
2589+
// StateError. This happens when _RenderTheater skips layout for an
2590+
// obscured OverlayEntry but selectables remain registered.
2591+
// Treat unlaid-out selectables as equal in sort order — they will be
2592+
// properly positioned on the next frame when layout completes.
2593+
// See https://github.com/flutter/flutter/issues/151536
2594+
return 0;
2595+
} on AssertionError {
2596+
// In debug mode, hasSize/debugNeedsLayout asserts fire before
2597+
// StateError. Catch both to prevent crashes in all build modes.
2598+
return 0;
25842599
}
2585-
return _compareHorizontally(rectA, rectB);
25862600
}
25872601

25882602
/// Compares two rectangles in the screen order solely by their vertical

‎packages/flutter/lib/src/widgets/text.dart‎

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1226,13 +1226,27 @@ class _SelectableTextContainerDelegate extends StaticSelectionContainerDelegate
12261226
static int _compareScreenOrder(Selectable a, Selectable b) {
12271227
// Attempt to sort the selectables under a [_SelectableTextContainerDelegate]
12281228
// by the top left rect.
1229-
final Rect rectA = MatrixUtils.transformRect(a.getTransformTo(null), a.boundingBoxes.first);
1230-
final Rect rectB = MatrixUtils.transformRect(b.getTransformTo(null), b.boundingBoxes.first);
1231-
final int result = _compareVertically(rectA, rectB);
1232-
if (result != 0) {
1233-
return result;
1229+
try {
1230+
final Rect rectA = MatrixUtils.transformRect(a.getTransformTo(null), a.boundingBoxes.first);
1231+
final Rect rectB = MatrixUtils.transformRect(b.getTransformTo(null), b.boundingBoxes.first);
1232+
final int result = _compareVertically(rectA, rectB);
1233+
if (result != 0) {
1234+
return result;
1235+
}
1236+
return _compareHorizontally(rectA, rectB);
1237+
} on StateError {
1238+
// In release mode, accessing `size` on an unlaid-out RenderBox throws
1239+
// StateError. This happens when _RenderTheater skips layout for an
1240+
// obscured OverlayEntry but selectables remain registered.
1241+
// Treat unlaid-out selectables as equal in sort order — they will be
1242+
// properly positioned on the next frame when layout completes.
1243+
// See https://github.com/flutter/flutter/issues/151536
1244+
return 0;
1245+
} on AssertionError {
1246+
// In debug mode, hasSize/debugNeedsLayout asserts fire before
1247+
// StateError. Catch both to prevent crashes in all build modes.
1248+
return 0;
12341249
}
1235-
return _compareHorizontally(rectA, rectB);
12361250
}
12371251

12381252
/// Compares two rectangles in the screen order solely by their vertical

‎packages/flutter/test/widgets/selectable_region_test.dart‎

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6977,8 +6977,50 @@ void main() {
69776977
expect(outerParagraph1.selections[0], const TextSelection(baseOffset: 4, extentOffset: 3));
69786978
expect(outerParagraph2.selections[0], const TextSelection(baseOffset: 2, extentOffset: 1));
69796979
});
6980+
6981+
testWidgets(
6982+
'MultiSelectableSelectionContainerDelegate._compareScreenOrder does not crash with unlaid-out selectables',
6983+
(WidgetTester tester) async {
6984+
// Regression test for https://github.com/flutter/flutter/issues/151536
6985+
//
6986+
// When _RenderTheater skips laying out an obscured OverlayEntry, selectables
6987+
// in that entry remain registered with their SelectionContainerDelegate but
6988+
// their RenderBoxes have no size. _flushAdditions then calls _compareScreenOrder
6989+
// which accesses paintBounds/getTransformTo and throws StateError in release
6990+
// mode / AssertionError in debug. This test drives
6991+
// MultiSelectableSelectionContainerDelegate._compareScreenOrder via multiple
6992+
// sibling Text widgets under a single SelectableRegion.
6993+
await tester.pumpWidget(
6994+
TestWidgetsApp(
6995+
home: Navigator(
6996+
pages: <Page<void>>[
6997+
TestPage<void>(
6998+
child: SelectableRegion(
6999+
selectionControls: emptyTextSelectionControls,
7000+
child: const Column(
7001+
children: <Widget>[
7002+
Text('Bottom page text A'),
7003+
Text('Bottom page text B'),
7004+
Text('Bottom page text C'),
7005+
],
7006+
),
7007+
),
7008+
),
7009+
const TestPage<void>(child: Text('Top page')),
7010+
],
7011+
onDidRemovePage: _noopRemovePage,
7012+
),
7013+
),
7014+
);
7015+
7016+
expect(tester.takeException(), isNull);
7017+
expect(find.text('Top page'), findsOneWidget);
7018+
},
7019+
);
69807020
}
69817021

7022+
void _noopRemovePage(Page<Object?> page) {}
7023+
69827024
class ColumnSelectionContainerDelegate extends StaticSelectionContainerDelegate {
69837025
/// Copies the selected contents of all [Selectable]s, separating their
69847026
/// contents with a new line.

‎packages/flutter/test/widgets/text_test.dart‎

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import 'package:flutter_test/flutter_test.dart';
1212
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
1313

1414
import 'semantics_tester.dart';
15+
import 'test_page_tester.dart';
1516

1617
void main() {
1718
const kBlack = Color(0xFF000000);
@@ -1869,8 +1870,57 @@ void main() {
18691870
);
18701871
expect(tester.getSize(find.byType(Text)), Size.zero);
18711872
});
1873+
1874+
testWidgets(
1875+
'_SelectableTextContainerDelegate._compareScreenOrder does not crash with unlaid-out fragments',
1876+
(WidgetTester tester) async {
1877+
// Regression test for https://github.com/flutter/flutter/issues/151536
1878+
//
1879+
// Drives _SelectableTextContainerDelegate._compareScreenOrder by using
1880+
// Text.rich with WidgetSpan children. Each WidgetSpan placeholder splits
1881+
// the text into a separate _SelectableFragment, so the delegate must sort
1882+
// them — which invokes the comparator that accesses boundingBoxes.first
1883+
// on each fragment. See paragraph.dart:_getSelectableFragments — fragments
1884+
// are only created when placeholder characters exist in the plain text.
1885+
final focusNode = FocusNode();
1886+
addTearDown(focusNode.dispose);
1887+
1888+
await tester.pumpWidget(
1889+
TestWidgetsApp(
1890+
home: Navigator(
1891+
pages: <Page<void>>[
1892+
TestPage<void>(
1893+
child: SelectableRegion(
1894+
focusNode: focusNode,
1895+
selectionControls: EmptyTextSelectionControls(),
1896+
child: const Text.rich(
1897+
TextSpan(
1898+
children: <InlineSpan>[
1899+
TextSpan(text: 'Before '),
1900+
WidgetSpan(child: SizedBox(width: 8, height: 8)),
1901+
TextSpan(text: ' middle '),
1902+
WidgetSpan(child: SizedBox(width: 8, height: 8)),
1903+
TextSpan(text: ' after'),
1904+
],
1905+
),
1906+
),
1907+
),
1908+
),
1909+
const TestPage<void>(child: Text('Top page')),
1910+
],
1911+
onDidRemovePage: _noopRemovePage,
1912+
),
1913+
),
1914+
);
1915+
1916+
expect(tester.takeException(), isNull);
1917+
expect(find.text('Top page'), findsOneWidget);
1918+
},
1919+
);
18721920
}
18731921

1922+
void _noopRemovePage(Page<Object?> page) {}
1923+
18741924
Future<void> _pumpTextWidget({
18751925
required WidgetTester tester,
18761926
required String text,

0 commit comments

Comments
 (0)