dev

davidhassell · davidhassell · commit bc68bd7aead3 · 2023-10-23T10:52:25.000+01:00
diff --git a/cf/field.py b/cf/field.py
@@ -166,7 +166,6 @@
         "sum",
         "var",
         "variance",
-        "sum",
         "sum_of_weights",
         "sum_of_weights2",
         "integral",
@@ -3772,7 +3771,7 @@ def weights(
                 if not measure:
                     w.override_units("1", inplace=True)
 
-                mn = w.minimum()
+                mn = w.min()
                 if mn <= 0:
                     raise ValueError(
                         "All weights must be positive. "
diff --git a/cf/test/create_test_files.py b/cf/test/create_test_files.py
@@ -7,9 +7,10 @@
 
 faulthandler.enable()  # to debug seg faults and timeouts
 
-import cfdm
 import netCDF4
 
+import cfdm
+
 VN = cfdm.CF()
 
 
diff --git a/cf/test/test_aggregate.py b/cf/test/test_aggregate.py
@@ -614,35 +614,35 @@ def test_aggregate_ugrid(self):
         """Test ugrid aggregation"""
         f = cf.example_field(8)
 
-        # Test that aggregation over a non-ugrid (time, in this case )
-        # axis works.
+        # Test that aggregation over a non-ugrid axis (time, in this
+        # case) works.
         g = f.copy()
         t = g.dim("T")
-        _ = cf.bounds_combination_mode("OR")
+        cf.bounds_combination_mode("OR")
         t += 72000
         a = cf.aggregate([f, g])
         self.assertEqual(len(a), 1)
         a = a[0]
         self.assertEqual(len(a.domain_topologies()), 1)
         self.assertEqual(len(a.cell_connectivities()), 1)
 
-        # Test that aggregation over non-ugrid axis doesn't work when
-        # the domain topology constructs are different
+        # Test that aggregation over a non-ugrid axis doesn't work
+        # when the domain topology constructs are different
         h = g.copy()
         d = h.domain_topology()
         d = d.data
         d += 1
         self.assertEqual(len(cf.aggregate([f, h])), 2)
 
-        # Test that aggregation over non-ugrid axis doesn't work when
-        # the cell connnectivty constructs are different
+        # Test that aggregation over a non-ugrid axis doesn't work
+        # when the cell connnectivty constructs are different
         h = g.copy()
         c = h.cell_connectivity()
         d = c.data
         d += 1
         self.assertEqual(len(cf.aggregate([f, h])), 2)
 
-        # Test that aggregation over ugrid axis doesn't work
+        # Test that aggregation over a ugrid axis doesn't work
         g = f.copy()
         x = g.aux("X")
         d = x.data
