Handle argrepr possibly not being populated#31
Merged
Conversation
With Python 3.14 at least one opcode (LOAD_SMALL_INT) seems to not populate argrepr when there is an argval. This is quite different from all other opcodes I've seen so far. I suspect this might be a bug with Python 3.14's dis module, but that's a digging session for another time (to be clear: dis.dis shows the value; but the Instruction from Bytecode doesn't have a populated argrepr). So here I change things so that I use argrepr if it is populated, otherwise I repr argval if it isn't None. Technically this could result in a false negative if there's a genuine None as the argval, but then I'd hope that argrepr is populated with "None".
Owner
Author
|
I've since reported what I noticed in the Python repo, in case it's a genuine bug: python/cpython#140256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Python 3.14 at least one opcode (
LOAD_SMALL_INT) seems to not populateargreprwhen there is anargval. This is quite different from all other opcodes I've seen so far. I suspect this might be a bug with Python 3.14'sdismodule, but that's a digging session for another time (to be clear:dis.disshows the value; but the Instruction fromBytecodedoesn't have a populatedargrepr).So here I change things so that I use
argreprif it is populated, otherwise Ireprargvalif it isn't None. Technically this could result in a false negative if there's a genuineNoneas theargval, but then I'd hope thatargrepris populated with"None".