Skip to content

[dmenu] Modified textbox password masking#2067

Merged
DaveDavenport merged 9 commits into
davatorium:nextfrom
Zebra2711:patch-1
Feb 8, 2025
Merged

[dmenu] Modified textbox password masking#2067
DaveDavenport merged 9 commits into
davatorium:nextfrom
Zebra2711:patch-1

Conversation

@Zebra2711

@Zebra2711 Zebra2711 commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

Use Unicode Character “●” (U+25CF) inteads '*'

Please follow these steps before submitting your PR:

  • This PR targets the next branch and not master
  • If your PR is a work in progress, include [WIP] in its title
  • Its commits' summaries are reasonably descriptive
  • You've described what this PR addresses below
  • You've included links to relevant issues, if any with #issue_num
  • You've deleted this template

Preview

polkit

Use Unicode Character “●” (U+25CF) inteads '*'
@TheGiraffe3

Copy link
Copy Markdown

Does this change the symbol across the board, or just for password entries?
If the entirety of Rofi is changed by this, it might be confusing.

@Zebra2711

Copy link
Copy Markdown
Contributor Author

Does this change the symbol across the board, or just for password entries? If the entirety of Rofi is changed by this, it might be confusing.

Only for password entries when use rofi -dmenu -password

@Zebra2711 Zebra2711 changed the title Modified textbox password masking [dmenu] Modified textbox password masking Jan 6, 2025
@DaveDavenport

Copy link
Copy Markdown
Collaborator

Is this utf-8 character available in all fonts?

@lbonn

lbonn commented Jan 7, 2025

Copy link
Copy Markdown
Collaborator

Some people might prefer *, or (?).

It's another customization thing, maybe use could change the password_mask_char in the configuration?

@DaveDavenport

Copy link
Copy Markdown
Collaborator

We could make it part of the theme, then users can easily override it in their config, and themes can customize it .

@Zebra2711

Zebra2711 commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

Change password_mask_char in theme config file:

...
inputbar {children:[prompt, entry];}
entry {password-mask:"<utf-8-char>";}
...

I found an issue: the cursor position is incorrect when entering a UTF-8 character or string into the textbox.

2025-01-08_15-50

password-mask:" "

@Zebra2711

Copy link
Copy Markdown
Contributor Author

I found an issue: the cursor position is incorrect when entering a UTF-8 character or string into the textbox.

Issue resolved.

@Zebra2711

Copy link
Copy Markdown
Contributor Author

@DaveDavenport Done for now

@Zebra2711 Zebra2711 closed this Jan 21, 2025
@Zebra2711 Zebra2711 deleted the patch-1 branch January 21, 2025 07:17
@Zebra2711 Zebra2711 restored the patch-1 branch January 21, 2025 07:18
@DaveDavenport

Copy link
Copy Markdown
Collaborator

?

@Zebra2711 Zebra2711 reopened this Jan 21, 2025
Comment thread source/widgets/textbox.c Outdated
@DaveDavenport DaveDavenport merged commit 1c144cc into davatorium:next Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants