Before opening a feature request
What is the user problem or growth opportunity you want to see solved?
I would like to display the URL of my desktop files with Type=Link while using drun.
How do you know that this problem exists today? Why is this important?
I've tried the intuitive way of displaying the '{exec}' field, but this is a null field when using URLs. I've also searched the source, hoping for an (undocumented) way to do this, but the code only checks for dr->exec (NULL), thusly this is currently impossible.
|
char *retv = helper_string_replace_if_exists( |
|
config.drun_display_format, "{generic}", egn, "{name}", en, "{comment}", |
|
ec, "{exec}", dr->exec, "{categories}", cats, "{keywords}", keywords, |
|
(char *)0); |
Note: it seems there may be a bug in the current implementation. Shouldn't dr->exec be escaped too (like name, comment, and generic_name)?
Who will benefit from it?
Anyone who wants to know what pressing a button would do (typically the same people that would display the {exec} field)
Rofi version (rofi -v)
Version: 1.7.1 (and HEAD)
Configuration
https://gist.github.com/aarondill/b809c4954f2d1147a2cfeebb83d20c20
Additional information
One of two implementations could be chosen:
- Create a new
{url} field, null if using Type=Application, like {exec} is for Type=Link
- Assign the
{exec} field to the URL when using Type=Link (more intuitive IMO)
Before opening a feature request
What is the user problem or growth opportunity you want to see solved?
I would like to display the
URLof my desktop files withType=Linkwhile using drun.How do you know that this problem exists today? Why is this important?
I've tried the intuitive way of displaying the '{exec}' field, but this is a null field when using URLs. I've also searched the source, hoping for an (undocumented) way to do this, but the code only checks for
dr->exec(NULL), thusly this is currently impossible.rofi/source/modes/drun.c
Lines 1338 to 1341 in 9cea843
Note: it seems there may be a bug in the current implementation. Shouldn't
dr->execbe escaped too (like name, comment, and generic_name)?Who will benefit from it?
Anyone who wants to know what pressing a button would do (typically the same people that would display the
{exec}field)Rofi version (rofi -v)
Version: 1.7.1 (and HEAD)
Configuration
https://gist.github.com/aarondill/b809c4954f2d1147a2cfeebb83d20c20
Additional information
One of two implementations could be chosen:
{url}field, null if using Type=Application, like{exec}is for Type=Link{exec}field to the URL when using Type=Link (more intuitive IMO)