This repository was archived by the owner on Jun 6, 2024. It is now read-only.
fix: update name rule logic to ignore incorrect kinds #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royhadad
previously approved these changes
Jul 11, 2023
royhadad
suggested changes
Jul 11, 2023
pkg/defaultRules/defaultRules.yaml
Outdated
| not: | ||
| enum: | ||
| - Kustomization | ||
| - ClusterRole |
Contributor
There was a problem hiding this comment.
This means ClusterRole can omit the name field altogether, I think this should be separated into 2 cases:
- enforce the
namefield for all relevant resources - enforce the
namefield format only for some of those resources
royhadad
suggested changes
Jul 11, 2023
Contributor
royhadad
left a comment
royhadad
left a comment
There was a problem hiding this comment.
I see some problems here, call me
royhadad
previously approved these changes
Jul 12, 2023
royhadad
approved these changes
Jul 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.